Allow following <summary> elements

jh-changes
Magnus Bergmark 7 years ago
parent 84a9655bb3
commit b45ffea6a4
No known key found for this signature in database
GPG Key ID: DB2D6BB84D8E0309
  1. 3
      src/content/components/common/follow.js
  2. 5
      test/content/components/common/follow.html
  3. 9
      test/content/components/common/follow.test.js

@ -5,7 +5,7 @@ import * as dom from 'shared/utils/dom';
const TARGET_SELECTOR = [
'a', 'button', 'input', 'textarea', 'area',
'[contenteditable=true]', '[contenteditable=""]', '[tabindex]',
'[role="button"]'
'[role="button"]', 'summary'
].join(',');
@ -155,6 +155,7 @@ export default class Follow {
case 'textarea':
return element.focus();
case 'button':
case 'summary':
return element.click();
default:
if (dom.isContentEditable(element)) {

@ -8,5 +8,10 @@
<div id='editable_div_1' contenteditable>link</div>
<div id='editable_div_2' contenteditable='true'>link</div>
<div id='x' contenteditable='false'>link</div>
<details>
<summary id='summary_1'>summary link</summary>
Some details
<a href='#'>not visible</a>
</details>
</body>
</html>

@ -11,10 +11,15 @@ describe('FollowComponent', () => {
window,
{ width: window.innerWidth, height: window.innerHeight },
{ x: 0, y: 0 });
expect(targets).to.have.lengthOf(3);
expect(targets).to.have.lengthOf(4);
let ids = Array.prototype.map.call(targets, (e) => e.id);
expect(ids).to.include.members(['visible_a', 'editable_div_1', 'editable_div_2']);
expect(ids).to.include.members([
'visible_a',
'editable_div_1',
'editable_div_2',
'summary_1',
]);
});
});
});