From b45ffea6a45de911710eb9868596987e27b5c707 Mon Sep 17 00:00:00 2001
From: Magnus Bergmark <magnus.bergmark@gmail.com>
Date: Mon, 16 Jul 2018 13:04:26 +0200
Subject: [PATCH] Allow following <summary> elements

---
 src/content/components/common/follow.js       | 3 ++-
 test/content/components/common/follow.html    | 5 +++++
 test/content/components/common/follow.test.js | 9 +++++++--
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/content/components/common/follow.js b/src/content/components/common/follow.js
index 2a55ea3..63ce603 100644
--- a/src/content/components/common/follow.js
+++ b/src/content/components/common/follow.js
@@ -5,7 +5,7 @@ import * as dom from 'shared/utils/dom';
 const TARGET_SELECTOR = [
   'a', 'button', 'input', 'textarea', 'area',
   '[contenteditable=true]', '[contenteditable=""]', '[tabindex]',
-  '[role="button"]'
+  '[role="button"]', 'summary'
 ].join(',');
 
 
@@ -155,6 +155,7 @@ export default class Follow {
     case 'textarea':
       return element.focus();
     case 'button':
+    case 'summary':
       return element.click();
     default:
       if (dom.isContentEditable(element)) {
diff --git a/test/content/components/common/follow.html b/test/content/components/common/follow.html
index eb0decd..b2a2d74 100644
--- a/test/content/components/common/follow.html
+++ b/test/content/components/common/follow.html
@@ -8,5 +8,10 @@
     <div id='editable_div_1' contenteditable>link</div>
     <div id='editable_div_2' contenteditable='true'>link</div>
     <div id='x' contenteditable='false'>link</div>
+    <details>
+      <summary id='summary_1'>summary link</summary>
+      Some details
+      <a href='#'>not visible</a>
+    </details>
   </body>
 </html>
diff --git a/test/content/components/common/follow.test.js b/test/content/components/common/follow.test.js
index 4fc11d0..90d6cf5 100644
--- a/test/content/components/common/follow.test.js
+++ b/test/content/components/common/follow.test.js
@@ -11,10 +11,15 @@ describe('FollowComponent', () => {
         window,
         { width: window.innerWidth, height: window.innerHeight },
         { x: 0, y: 0 });
-      expect(targets).to.have.lengthOf(3);
+      expect(targets).to.have.lengthOf(4);
 
       let ids = Array.prototype.map.call(targets, (e) => e.id);
-      expect(ids).to.include.members(['visible_a', 'editable_div_1', 'editable_div_2']);
+      expect(ids).to.include.members([
+        'visible_a',
+        'editable_div_1',
+        'editable_div_2',
+        'summary_1',
+      ]);
     });
   });
 });