Commit graph

51 commits

Author SHA1 Message Date
Stacy Harper
262418637f Rework of the sxmo_modemtext with benefit
* Draft files are assigned to each number:

Stored here ".local/share/modem/+33666666666/draft.txt"
We automatically edit this single file, making crash or unexpected
edition issue to leave intact saved draft.

* Simplification of some logics

Having a known draft file instead of using a TEXT var simplify lots
of things

* EDITOR is not run in a subshell

Some editors as kakoune got issues with that. Futhermore, it will be
usefull for some other development as making all menu ssh mode
compatible

* Remove modem check

As we now got draft, why do we care if modem is up or down ?

* Display the contact name instead of it number in the conversation

Or use "Unknown Number (+337798676)"

* Unify display message notif adding possibilities to bypass the
main menu

Signed-off-by: Stacy Harper <contact@stacyharper.net>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2021-04-05 12:00:49 +02:00
Maarten van Gompel
da3dba4bfb minor fixes to satisfy shellcheck 2021-03-31 20:14:53 +02:00
Maarten van Gompel
cdadb27884 implemented simple unlock sim script using dmenu 2021-03-31 11:42:21 +02:00
Maarten van Gompel
c5c8f3d514 Modem monitor now tracks the modem for state changes and shows the state in the status bar 2021-03-31 11:42:21 +02:00
Stacy Harper
18361bd681 Revert "Use less as sms pager to allow scrollback"
This reverts commit 3bb3fb6094.

We cannot use this special less argument as it is not busybox less
compatible.

I add busybox aliases to not reproduce the error in the future.

Signed-off-by: Stacy Harper <contact@stacyharper.net>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2021-03-30 19:08:17 +02:00
Stacy Harper
568eac7dd3 Add a dsubmenu to reply/call on SMS windows
Signed-off-by: Stacy Harper <contact@stacyharper.net>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2021-03-27 23:22:40 +01:00
Stacy Harper
378fe01738 Add a missed call hook
Signed-off-by: Stacy Harper <contact@stacyharper.net>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2021-03-17 20:57:51 +01:00
Maarten van Gompel
f4ba3978c9 Call common script, moved icons to common script, removed unnecessary aliases from common (let's add them only when there are conflicts), made sure plays along with shellcheck 2021-02-01 18:32:32 +01:00
Maarten van Gompel
c58fa6a1e9 Added an option (extra notification) to discard an incoming call #157 2021-01-30 21:41:08 +01:00
Maarten van Gompel
24f8ed8478 wait for modem for a bit when it is not immediately available yet (e.g. after crust wakeup) 2021-01-30 21:41:08 +01:00
Maarten van Gompel
1608ab1ae4 increased verbosity in various scripts, and do not run xargs kill when argument is empty (cleaner and clearer stderr messages) 2021-01-30 21:41:08 +01:00
Maarten van Gompel
a42f160ed2 make modemmonitor's dbus hooks more robust and prevent being triggered multiple times 2020-12-09 15:46:21 +01:00
Maarten van Gompel
9a4df9fd28 reworking handling finished/missed calls #134 2020-12-09 15:46:21 +01:00
Maarten van Gompel
2a07cab638 implemented lookupcontactname() in call/text handler, removes non posix-compliant substitutions 2020-12-09 15:46:21 +01:00
Maarten van Gompel
4a90d86f56 Sane message when terminating call with unknown number and more verbose output to stderr from modem scripts 2020-12-09 15:46:21 +01:00
Anjandev Momi
e067fd9ad6 Revert "simplify code to get phone number for incoming calls"
This reverts commit b0bb9ac9fc.

This fixes the issue with modemlog having filled with extra mmcli
output
2020-12-05 23:16:59 -05:00
Anjandev Momi
741defe781 Fix short phone numbers or phone numbers with text do not appear in scripts
Fixes #106

Signed-off-by: Anjandev Momi <anjan@momi.ca>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2020-12-04 22:00:29 +01:00
Anjandev Momi
b0bb9ac9fc simplify code to get phone number for incoming calls
This code uses fewer programs and the code now matches the code for
getting phone number of incoming text.

Signed-off-by: Anjandev Momi <anjan@momi.ca>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2020-12-04 22:00:29 +01:00
Miles Alan
96931ce22c Add back saftey hook for incoming calls to delete notifications if none incoming 2020-11-20 17:30:06 +01:00
Miles Alan
f2fc6a406e Missed call rework: Use dbus to check for missed calls & properly delete pickup
Use dbus to monitor for missed calls. Missed calls used to work but had a
regression due to the work to make text/calls used dbus. This adds the proper
dbus hook for missed calls as well and also changes the incoming call
notification to allow for multiple incoming calls (theoretically).

Tested for a single caller and transitioning the pickup notification
into a missed call notification and all is working good.
2020-11-20 17:27:37 +01:00
Anjandev Momi
e11cf9e523 move sxmo data to XDG_DATA_HOME
Breaking change. Make sure you send an email to the mailing list
telling users to move their
$XDG_CONFIG_HOME/{modem,notifications} files/folders to
$XDG_DATA_HOME

Signed-off-by: Anjandev Momi <anjan@momi.ca>
2020-11-08 19:45:39 -05:00
Reed Wade
cd7762d92a The ring hook was blocking the notification writing.
The hook must be run asynchronously. This allow ringtones to be played
using mpv by exemple.

Signed-off-by: Reed Wade <reedwade@misterbanal.net>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2020-11-08 14:33:26 +01:00
Maarten van Gompel
e11d3aaea3 some minor cleanup of issues detected by shellcheck after applying the patch: 'modemmonitor: use dbus-monitor' 2020-10-31 22:37:21 +01:00
Reed Wade
1e00b72d90 fix a notification bug when sms come from whitespace content number
We quote the sms path on notificationwrite to prevent buggy commands.

mn: This patch fixes texts from numbers like "CREDIT AGRICOLE"

Signed-off-by: Reed Wade <reedwade@misterbanal.net>
Signed-off-by: Anjandev Momi <anjan@momi.ca>
2020-10-31 13:35:52 -04:00
Maarten van Gompel
19efcf927e Sep 8: call checkformissedcalls at first run, and then also any time that checkforincomingcalls did not actually find a call (i.e. ... missed it)
Signed-off-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2020-10-31 13:09:35 +01:00
Serge E. Hallyn
99099a359f modemmonitor: use dbus-monitor
Instead of looping over mmcli commands to check for incoming
calls and texts every 3s, use dbus-monitor to tell us when
something is coming in.  This should save some battery life
as well as reduce the delay in new call/msg notification.

I was running on the latest released scripts, so have not
strictly tested this with git master.  Note that I dropped
the call to checkmissedcalls.  Perhaps we should still run
that at firststart?

Signed-off-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Maarten van Gompel <proycon@anaproy.nl>
2020-10-31 13:06:28 +01:00
Anjandev Momi
c94e58f6d2 modemmonitor: fixed no contact name displayed in notifications and new folders without + 2020-09-15 19:27:56 -05:00
Miles Alan
4c24155a62 Don't delete leading + from incoming calls in sxmo_modemmonitor.sh 2020-09-13 09:14:08 -05:00
Sam Bowlby
93de0d4d84 correct variable name for incoming text number used in sms hook 2020-08-31 22:13:51 -05:00
Maarten van Gompel
565eae8835 Updated handling of '+' in phone numbers, it is now never stripped but expected: all numbers should be full international phone numbers (including in contacts.tsv).
Ensure contacts from modem and contacts lists are all fully qualified phone numbers (starting with + and carrying a country prefix). This effectively filters out older/incompatible entries.
2020-08-26 23:24:27 -05:00
Miles Alan
747da7863c Fix shellcheck 2020-08-22 16:45:49 -05:00
Miles Alan
17fb103ee3 Create a new notification when there is a missed call 2020-08-22 13:44:05 -05:00
Miles Alan
c5b665ca4f Look for ATTRIB events for notifications updates; remove "Pickup" menu
Picking up call can be done from both dunst notification & notifications menu;
so for more consistency / less bugs the Pickup menu entry has been removed.
2020-08-22 12:21:51 -05:00
Maarten van Gompel
7ec9ca2db1 pass incoming phone number to the ring hook (allows distinctive rings/actions based on caller) and added a similar sms hook 2020-08-18 20:59:22 -05:00
Miles Alan
faf9bfc48d Refactor notifications work to use 1 interface for writing notifs & use dates
Summary of changes:
1. Always use the sxmo_notificationwrite.sh script to write notifications
   rather then sometimes using echo to the DIR
2. Reorder args for notiffile spec to be action as 1st line, watchfile 2nd, and
   rest as msg; this way msg can be multiple lines without propogating bugs
3. Write calls as a standard notification via sxmo_notificationwrite.sh
4. Use datestamps from notification files instead of filename, this way (3)
   works without extra logic
5. Various style fixes
2020-08-05 23:32:39 -05:00
iressa
e6635ba7ef Notification patch v4 2020-08-05 23:32:39 -05:00
Miles Alan
36520d487e Change ring hook location to ~/.config/sxmo/hooks/ring 2020-07-18 10:38:28 -05:00
Dmytro
9378530a1b Ringing sound configurable
Signed-off-by: Miles Alan <m@milesalan.com>
2020-07-18 10:38:28 -05:00
Miles Alan
844ce9ddef Plus prefix strip numbers before storing into modem log 2020-06-29 15:24:34 -05:00
Miles Alan
a032e4923e Remove +1 stripping from numbers in modem scripts
Note prefix stripping was unreliable because any +1XX number would break things.
The advice should be to always dial with +1 / international prefixes and store
contacts in your contacts.tsv with international codes; this way we avoid any
duplicate errors since we can be assured things in mmcli always come back w/
international prefixing automatically.
2020-06-29 11:43:22 -05:00
Miles Alan
a4b2724c4a Clean up modem functionality & don't ever kill dmenu; move call monitoring to call script 2020-06-19 17:57:43 -05:00
Miles Alan
049a93e5d8 Shellcheck and tabindent all scripts 2020-06-13 20:36:13 -05:00
Anjandev Momi
1b78c3cf2f modem: use XDG_CONFIG_HOME to save logs
Signed-off-by: Miles Alan <m@milesalan.com>
2020-06-07 10:05:46 -05:00
Miles Alan
6777dbdebd Fix bug w/ newcall() in sxmo_modemmonitor.sh preventing ringing call from being logged
Resolves sxmo-tickets #26 reported by ~jan_wagemakers
2020-05-25 14:55:26 -05:00
Miles Alan
ba8e8b0b9a Fix typo when modem not found you're -> your 2020-05-22 21:55:56 -05:00
Miles Alan
fa3550c638 Add warnings to modem scripts if the modem is not present 2020-05-20 17:18:02 -05:00
Miles Alan
34b2c57038 Fixes related to cleaning up modem functionality; fix audio; add flash toggle 2020-05-17 18:59:47 -05:00
Miles Alan
8b52988ad2 Remove sudo from mmcli commands in modem scripts 2020-05-11 22:13:15 -05:00
Miles Alan
e5877059ff Lots of bugfixes related to calling/modem and various script fixes 2020-05-11 20:55:47 -05:00
Miles Alan
22d974f22f Cleanup calling - mostly working; misc cleanup scripts; add vibrate program 2020-05-11 20:54:54 -05:00