various minor shellcheck fixes

scripts/core/sxmo_common.sh

@@ -32,7 +32,7 @@ command -v "$EDITOR" > /dev/null || export EDITOR=vis
 # user's computer
 
 #aliases aren't expanded in bash
-# shellcheck disable=SC2039
+# shellcheck disable=SC2039,SC3044
 command -v shopt > /dev/null && shopt -s expand_aliases
 
 alias dmenu="sxmo_dmenu.sh"

scripts/core/sxmo_open.sh

@@ -42,7 +42,7 @@ get_mimeapps_entries_from_desktop_dir() {
 		grep --include "*.desktop" '^MimeType=' "$desktop_path" \
 		| tr ';' '\n' \
 		| cut -d= -f2 \
-		| xargs -i{} printf "%s=%s\n" "{}" "$(basename "$desktop_path")"
+		| xargs -I{} printf "%s=%s\n" "{}" "$(basename "$desktop_path")"
 	done
 }
 

scripts/core/sxmo_screenlock.sh

@@ -24,9 +24,9 @@ saveAllEventCounts() {
 }
 
 whichWake() {
-	if [ "$(cat $WAKEUPRTC)" -gt "$(cat $OLD_RTC_WAKECOUNT)" ] ; then
+	if [ "$(cat "$WAKEUPRTC")" -gt "$(cat "$OLD_RTC_WAKECOUNT")" ] ; then
 		echo "rtc"
-	elif [ "$(cat $MODEMUPRTC)" -gt "$(cat $OLD_MODEM_WAKECOUNT)" ] ; then
+	elif [ "$(cat "$MODEMUPRTC")" -gt "$(cat "$OLD_MODEM_WAKECOUNT")" ] ; then
 		echo "modem"
 	else
 		# button does not have a active count so if it's none of the above, it has to be the button

scripts/core/sxmo_xinit.sh

@@ -104,7 +104,7 @@ customxinit() {
 	# shellcheck disable=SC1090
 	[ ! -e "$XDG_CONFIG_HOME/sxmo/xinit" ] && defaultconfig
 
-	# shellcheck disable=SC1090
+	# shellcheck disable=SC1090,SC1091
 	. "$XDG_CONFIG_HOME/sxmo/xinit"
 	set +o allexport
 }

scripts/modem/sxmo_unlocksim.sh

@@ -23,7 +23,7 @@ else
 	pkill dmenu #kill existing dmenu
 	while [ $retry -eq 1 ]; do
 		PICKED="$(
-			# shellcheck disable=SC2039
+			# shellcheck disable=SC2039,SC3037
 			echo -e "Cancel\n0000\n1234" | sxmo_dmenu_with_kb.sh -l 3 -c -p "PIN:" | tr -d "\n\r "
 		)"
 		if [ -n "$PICKED" ] && [ "$PICKED" != "Cancel" ]; then