Shellcheck a few core scripts

scripts/core/sxmo_camera.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env sh
 err() {
-  echo -e "$1" | dmenu -fn Terminus-20 -c -l 10
+	printf %b "$1" | dmenu -fn Terminus-20 -c -l 10
 	exit 1
 }
 

scripts/core/sxmo_rotate.sh

@@ -25,7 +25,7 @@ rotright() {
 }
 
 rotate() {
-  isrotated && rotnormal || rotright
+	if isrotated; then rotnormal; else rotright; fi
 }
 
 rotate

scripts/core/sxmo_vol.sh

@@ -20,7 +20,7 @@ down() {
 	notify
 }
 setvol() {
-  amixer set "$(sxmo_audiocurrentdevice.sh)" $1
+	amixer set "$(sxmo_audiocurrentdevice.sh)" "$1"
 }
 
-$@
+$1

scripts/core/sxmo_xinit.sh

@@ -1,8 +1,8 @@
 #!/usr/bin/env sh
 # Env vars
-source /etc/profile
+. /etc/profile
-which $TERM || export TERM=st
+which "$TERM" || export TERM=st
-which $BROWSER || export BROWSER=surf
+which "$BROWSER" || export BROWSER=surf
 [ -z "$MOZ_USE_XINPUT2" ] && export MOZ_USE_XINPUT2=1
 [ -z "$XDG_CONFIG_HOME" ] && export XDG_CONFIG_HOME=~/.config
 
@@ -24,16 +24,9 @@ autocutsel &
 autocutsel -selection PRIMARY &
 sxmo_statusbar.sh &
 
-# Start dunst, lisgd (after dunst so it's in dbus path) and dwm
+# Startup dbus, dunst in dbus path, lisgd in dbus path, and finally dwm
-LEGACYSXMOFOLDERWARNING="
-Warning: ~/.sxmo is deprecated since sxmo-utils 1.1.5.
-Modem call logs/texts location have moved.
-Please move the contents of the ~/.sxmo/ folder to $XDG_CONFIG_HOME/sxmo/modem/
-"
-
 exec dbus-run-session sh -c "
 	dunst -conf /usr/share/sxmo/dunst.conf &
 	lisgd &
-  [ -d "/home/$USER/.sxmo" ] && notify-send -t 0 -u critical '$LEGACYSXMOFOLDERWARNING' &
 	dwm 2> ~/.dwm.log
 "