jab2870/sxmo-utils
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

sxmo_audio*: properly set vars with default values if they are unset

Browse source 
A mistake from implementing this resulted in the shell trying to expand
the 'word' part (e.g. "Line Out"), when the var was unset or null.
Obviously those are are strings and not expandable.

Signed-off-by: Anjandev Momi <anjan@momi.ca>
This commit is contained in:
Clayton Craft 2021-04-23 20:08:45 -07:00 • committed by Anjandev Momi
parent 7d9b86b54c
commit 2d9740f252
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/core/sxmo_audiocurrentdevice.sh
View file

@ -1,7 +1,7 @@
#!/usr/bin/env sh
${SPEAKER:-"Line Out"}
${HEADPHONE:-"Headphone"}
${EARPIECE:-"Earpiece"}
SPEAKER=${SPEAKER:-"Line Out"}
HEADPHONE=${HEADPHONE:-"Headphone"}
EARPIECE=${EARPIECE:-"Earpiece"}
audiodevice() {
amixer sget "$EARPIECE" | grep -qE '\[on\]' && echo "$EARPIECE" && return

6
scripts/core/sxmo_audioout.sh
View file

@ -5,9 +5,9 @@ ARG="$1"
# shellcheck source=scripts/core/sxmo_common.sh
. "$(dirname "$0")/sxmo_common.sh"
${SPEAKER:-"Line Out"}
${HEADPHONE:-"Headphone"}
${EARPIECE:-"Earpiece"}
SPEAKER="${SPEAKER:-"Line Out"}"
HEADPHONE="${HEADPHONE:-"Headphone"}"
EARPIECE="${EARPIECE:-"Earpiece"}"
amixer set "$SPEAKER" mute
amixer set "$HEADPHONE" mute