remove unused actions and fix test

jh-changes
Shin'ya Ueoka 7 years ago
parent e3409b3aae
commit fe8a928317
  1. 10
      src/content/actions/find.js
  2. 2
      src/content/actions/index.js
  3. 9
      src/content/reducers/find.js
  4. 19
      test/content/actions/find.test.js
  5. 33
      test/content/reducers/find.test.js

@ -14,14 +14,6 @@ const postPatternNotFound = (pattern) => {
'Pattern not found: ' + pattern); 'Pattern not found: ' + pattern);
}; };
const show = () => {
return { type: actions.FIND_SHOW };
};
const hide = () => {
return { type: actions.FIND_HIDE };
};
const find = (string, backwards) => { const find = (string, backwards) => {
let caseSensitive = false; let caseSensitive = false;
let wrapScan = true; let wrapScan = true;
@ -60,4 +52,4 @@ const prev = (keyword, reset) => {
return findNext(keyword, reset, true); return findNext(keyword, reset, true);
}; };
export { show, hide, next, prev }; export { next, prev };

@ -23,7 +23,5 @@ export default {
FOLLOW_CONTROLLER_BACKSPACE: 'follow.controller.backspace', FOLLOW_CONTROLLER_BACKSPACE: 'follow.controller.backspace',
// Find // Find
FIND_SHOW: 'find.show',
FIND_HIDE: 'find.hide',
FIND_SET_KEYWORD: 'find.set.keyword', FIND_SET_KEYWORD: 'find.set.keyword',
}; };

@ -1,21 +1,12 @@
import actions from 'content/actions'; import actions from 'content/actions';
const defaultState = { const defaultState = {
enabled: false,
keyword: '', keyword: '',
found: false, found: false,
}; };
export default function reducer(state = defaultState, action = {}) { export default function reducer(state = defaultState, action = {}) {
switch (action.type) { switch (action.type) {
case actions.FIND_SHOW:
return Object.assign({}, state, {
enabled: true,
});
case actions.FIND_HIDE:
return Object.assign({}, state, {
enabled: false,
});
case actions.FIND_SET_KEYWORD: case actions.FIND_SET_KEYWORD:
return Object.assign({}, state, { return Object.assign({}, state, {
keyword: action.keyword, keyword: action.keyword,

@ -1,19 +0,0 @@
import { expect } from "chai";
import actions from 'content/actions';
import * as findActions from 'content/actions/find';
describe("find actions", () => {
describe("show", () => {
it('create FIND_SHOW action', () => {
let action = findActions.show();
expect(action.type).to.equal(actions.FIND_SHOW);
});
});
describe("hide", () => {
it('create FIND_HIDE action', () => {
let action = findActions.hide();
expect(action.type).to.equal(actions.FIND_HIDE);
});
});
});

@ -5,32 +5,19 @@ import findReducer from 'content/reducers/find';
describe("find reducer", () => { describe("find reducer", () => {
it('return the initial state', () => { it('return the initial state', () => {
let state = findReducer(undefined, {}); let state = findReducer(undefined, {});
expect(state).to.have.property('enabled', false);
expect(state).to.have.property('keyword', ''); expect(state).to.have.property('keyword', '');
}); expect(state).to.have.property('found', false);
it('return next state for FIND_SHOW', () => {
let action = { type: actions.FIND_SHOW };
let prev = { enabled: false };
let state = findReducer(prev, action);
expect(state.enabled).is.equal(true);
});
it('return next state for FIND_HIDE', () => {
let action = { type: actions.FIND_HIDE };
let prev = { enabled: true };
let state = findReducer(prev, action);
expect(state.enabled).is.equal(false);
}); });
it('return next state for FIND_SET_KEYWORD', () => { it('return next state for FIND_SET_KEYWORD', () => {
let action = { type: actions.FIND_SET_KEYWORD, keyword: 'my-search' }; let action = {
let state = { enabled: true, keyword: '' }; type: actions.FIND_SET_KEYWORD,
keyword: 'xyz',
state = findReducer(state, action); found: true,
};
expect(state.keyword).is.equal('my-search'); let state = findReducer({}, action);
expect(state.keyword).is.equal('xyz');
expect(state.found).to.be.true;
}); });
}); });