remove unused actions and fix test
This commit is contained in:
parent
e3409b3aae
commit
fe8a928317
5 changed files with 10 additions and 61 deletions
|
@ -14,14 +14,6 @@ const postPatternNotFound = (pattern) => {
|
|||
'Pattern not found: ' + pattern);
|
||||
};
|
||||
|
||||
const show = () => {
|
||||
return { type: actions.FIND_SHOW };
|
||||
};
|
||||
|
||||
const hide = () => {
|
||||
return { type: actions.FIND_HIDE };
|
||||
};
|
||||
|
||||
const find = (string, backwards) => {
|
||||
let caseSensitive = false;
|
||||
let wrapScan = true;
|
||||
|
@ -60,4 +52,4 @@ const prev = (keyword, reset) => {
|
|||
return findNext(keyword, reset, true);
|
||||
};
|
||||
|
||||
export { show, hide, next, prev };
|
||||
export { next, prev };
|
||||
|
|
|
@ -23,7 +23,5 @@ export default {
|
|||
FOLLOW_CONTROLLER_BACKSPACE: 'follow.controller.backspace',
|
||||
|
||||
// Find
|
||||
FIND_SHOW: 'find.show',
|
||||
FIND_HIDE: 'find.hide',
|
||||
FIND_SET_KEYWORD: 'find.set.keyword',
|
||||
};
|
||||
|
|
|
@ -1,21 +1,12 @@
|
|||
import actions from 'content/actions';
|
||||
|
||||
const defaultState = {
|
||||
enabled: false,
|
||||
keyword: '',
|
||||
found: false,
|
||||
};
|
||||
|
||||
export default function reducer(state = defaultState, action = {}) {
|
||||
switch (action.type) {
|
||||
case actions.FIND_SHOW:
|
||||
return Object.assign({}, state, {
|
||||
enabled: true,
|
||||
});
|
||||
case actions.FIND_HIDE:
|
||||
return Object.assign({}, state, {
|
||||
enabled: false,
|
||||
});
|
||||
case actions.FIND_SET_KEYWORD:
|
||||
return Object.assign({}, state, {
|
||||
keyword: action.keyword,
|
||||
|
|
|
@ -1,19 +0,0 @@
|
|||
import { expect } from "chai";
|
||||
import actions from 'content/actions';
|
||||
import * as findActions from 'content/actions/find';
|
||||
|
||||
describe("find actions", () => {
|
||||
describe("show", () => {
|
||||
it('create FIND_SHOW action', () => {
|
||||
let action = findActions.show();
|
||||
expect(action.type).to.equal(actions.FIND_SHOW);
|
||||
});
|
||||
});
|
||||
|
||||
describe("hide", () => {
|
||||
it('create FIND_HIDE action', () => {
|
||||
let action = findActions.hide();
|
||||
expect(action.type).to.equal(actions.FIND_HIDE);
|
||||
});
|
||||
});
|
||||
});
|
|
@ -5,32 +5,19 @@ import findReducer from 'content/reducers/find';
|
|||
describe("find reducer", () => {
|
||||
it('return the initial state', () => {
|
||||
let state = findReducer(undefined, {});
|
||||
expect(state).to.have.property('enabled', false);
|
||||
expect(state).to.have.property('keyword', '');
|
||||
});
|
||||
|
||||
it('return next state for FIND_SHOW', () => {
|
||||
let action = { type: actions.FIND_SHOW };
|
||||
let prev = { enabled: false };
|
||||
let state = findReducer(prev, action);
|
||||
|
||||
expect(state.enabled).is.equal(true);
|
||||
});
|
||||
|
||||
it('return next state for FIND_HIDE', () => {
|
||||
let action = { type: actions.FIND_HIDE };
|
||||
let prev = { enabled: true };
|
||||
let state = findReducer(prev, action);
|
||||
|
||||
expect(state.enabled).is.equal(false);
|
||||
expect(state).to.have.property('found', false);
|
||||
});
|
||||
|
||||
it('return next state for FIND_SET_KEYWORD', () => {
|
||||
let action = { type: actions.FIND_SET_KEYWORD, keyword: 'my-search' };
|
||||
let state = { enabled: true, keyword: '' };
|
||||
let action = {
|
||||
type: actions.FIND_SET_KEYWORD,
|
||||
keyword: 'xyz',
|
||||
found: true,
|
||||
};
|
||||
let state = findReducer({}, action);
|
||||
|
||||
state = findReducer(state, action);
|
||||
|
||||
expect(state.keyword).is.equal('my-search');
|
||||
expect(state.keyword).is.equal('xyz');
|
||||
expect(state.found).to.be.true;
|
||||
});
|
||||
});
|
||||
|
|
Reference in a new issue