fix but failed

This commit is contained in:
Shin'ya Ueoka 2018-06-28 20:44:57 +09:00
parent 03cf265eff
commit e2fb33bdc5
20 changed files with 74 additions and 98 deletions

View file

@ -100,7 +100,7 @@ class KeymapsForm extends Component {
return;
}
let next = Object.assign({}, this.props.value);
let next = { ...this.props.value };
next[e.target.name] = e.target.value;
this.props.onChange(next);

View file

@ -44,7 +44,7 @@ class PropertiesForm extends Component {
}
let name = e.target.name;
let next = Object.assign({}, this.props.value);
let next = { ...this.props.value };
if (e.target.type.toLowerCase() === 'checkbox') {
next[name] = e.target.checked;
} else if (e.target.type.toLowerCase() === 'number') {

View file

@ -53,10 +53,10 @@ class SearchForm extends Component {
let value = this.props.value;
let name = e.target.name;
let index = e.target.getAttribute('data-index');
let next = Object.assign({}, {
let next = {
default: value.default,
engines: value.engines ? value.engines.slice() : [],
});
};
if (name === 'name') {
next.engines[index][0] = e.target.value;

View file

@ -134,7 +134,7 @@ class SettingsComponent extends Component {
}
validateValue(e) {
let next = Object.assign({}, this.state);
let next = { ...this.state };
next.errors.json = '';
try {
@ -146,18 +146,16 @@ class SettingsComponent extends Component {
}
bindForm(name, value) {
let next = Object.assign({}, this.state, {
settings: Object.assign({}, this.state.settings, {
form: Object.assign({}, this.state.settings.form)
})
});
let next = { ...this.state,
settings: { ...this.state.settings,
form: { ...this.state.settings.form }}};
next.settings.form[name] = value;
this.setState(next);
this.context.store.dispatch(settingActions.save(next.settings));
}
bindValue(e) {
let next = Object.assign({}, this.state);
let next = { ...this.state };
let error = false;
next.errors.json = '';
@ -190,7 +188,7 @@ class SettingsComponent extends Component {
let form = settingsValues.formFromJson(
this.state.settings.json, KeymapsForm.AllowdOps);
let next = Object.assign({}, this.state);
let next = { ...this.state };
next.settings.form = form;
next.settings.source = 'form';
next.errors.json = '';
@ -201,7 +199,7 @@ class SettingsComponent extends Component {
migrateToJson() {
let json = settingsValues.jsonFromForm(this.state.settings.form);
let next = Object.assign({}, this.state);
let next = { ...this.state };
next.settings.json = json;
next.settings.source = 'json';
next.errors.json = '';