jab2870
/
Vim-Vixen
Archived
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add e2e tests for completions

Browse Source
jh-changes
Shin'ya Ueoka 6 years ago
parent afdd9562e4
commit 9f7150e96b
4 changed files with 220 additions and 8 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 7
      QA.md
  2. 136
      e2e/completion.test.js
  3. 75
      e2e/completion_set.test.js
  4. 10
      e2e/lib/Console.js

7
QA.md
Unescape View File

@ -35,13 +35,6 @@ The behaviors of the console are tested in [Console section](#consoles).
- [ ] `<EMPTY>`: do nothing - [ ] `<EMPTY>`: do nothing
### Completions
#### History and search engines
- [ ] `set `: show prperties starts with keywords
- [ ] Complete commands matched with input keywords in the prefix.
#### Misc #### Misc
- [ ] Select next item by <kbd>Tab</kbd> and previous item by <kbd>Shift</kbd>+<kbd>Tab</kbd> - [ ] Select next item by <kbd>Tab</kbd> and previous item by <kbd>Shift</kbd>+<kbd>Tab</kbd>

136
e2e/completion.test.js
Unescape View File

@ -0,0 +1,136 @@
const express = require('express');
const lanthan = require('lanthan');
const path = require('path');
const assert = require('assert');
const eventually = require('./eventually');
const settings = require('./settings');
const Console = require('./lib/Console');
const Key = lanthan.Key;
const newApp = () => {
let app = express();
app.get('/', (req, res) => {
res.send(`<!DOCTYPEhtml>
<html lang="en">
<body>ok</body>
</html">`);
});
return app;
};
describe("general completion test", () => {
const port = 12321;
let http;
let firefox;
let session;
let browser;
let body;
before(async() => {
firefox = await lanthan.firefox({
spy: path.join(__dirname, '..'),
builderf: (builder) => {
builder.addFile('build/settings.js');
},
});
session = firefox.session;
browser = firefox.browser;
http = newApp().listen(port);
await browser.storage.local.set({
settings,
});
});
after(async() => {
http.close();
if (firefox) {
await firefox.close();
}
});
beforeEach(async() => {
await session.navigateTo(`http://127.0.0.1:${port}`);
body = await session.findElementByCSS('body');
});
it('should all commands on empty line', async() => {
await body.sendKeys(':');
await session.switchToFrame(0);
let c = new Console(session);
await eventually(async() => {
let items = await c.getCompletions();
assert.equal(items.length, 10);
assert.deepEqual(items[0], { type: 'title', text: 'Console Command' });
assert(items[1].text.startsWith('set'))
assert(items[2].text.startsWith('open'))
assert(items[3].text.startsWith('tabopen'))
});
});
it('should only commands filtered by prefix', async() => {
await body.sendKeys(':');
await session.switchToFrame(0);
let c = new Console(session);
await c.sendKeys('b');
await eventually(async() => {
let items = await c.getCompletions();
assert.equal(items.length, 4);
assert.deepEqual(items[0], { type: 'title', text: 'Console Command' });
assert(items[1].text.startsWith('buffer'))
assert(items[2].text.startsWith('bdelete'))
assert(items[3].text.startsWith('bdeletes'))
});
});
it('selects completion items by <Tab>/<S-Tab> keys', async() => {
await body.sendKeys(':');
await session.switchToFrame(0);
let c = new Console(session);
await c.sendKeys('b');
await eventually(async() => {
let items = await c.getCompletions();
assert.equal(items.length, 4);
});
await c.sendKeys(Key.Tab);
await eventually(async() => {
let items = await c.getCompletions();
assert(items[1].highlight)
let v = await c.currentValue();
assert.equal(v, 'buffer');
});
await c.sendKeys(Key.Tab, Key.Tab);
await eventually(async() => {
let items = await c.getCompletions();
assert(items[3].highlight)
let v = await c.currentValue();
assert.equal(v, 'bdeletes');
});
await c.sendKeys(Key.Tab);
await eventually(async() => {
let v = await c.currentValue();
assert.equal(v, 'b');
});
await c.sendKeys(Key.Shift, Key.Tab);
await eventually(async() => {
let items = await c.getCompletions();
assert(items[3].highlight)
let v = await c.currentValue();
assert.equal(v, 'bdeletes');
});
});
});

75
e2e/completion_set.test.js
Unescape View File

@ -0,0 +1,75 @@
const express = require('express');
const lanthan = require('lanthan');
const path = require('path');
const assert = require('assert');
const eventually = require('./eventually');
const settings = require('./settings');
const Console = require('./lib/Console');
const Key = lanthan.Key;
describe("completion on set commands", () => {
const port = 12321;
let firefox;
let session;
let browser;
let body;
before(async() => {
firefox = await lanthan.firefox({
spy: path.join(__dirname, '..'),
builderf: (builder) => {
builder.addFile('build/settings.js');
},
});
session = firefox.session;
browser = firefox.browser;
await browser.storage.local.set({
settings,
});
});
after(async() => {
if (firefox) {
await firefox.close();
}
});
beforeEach(async() => {
await session.navigateTo(`about:blank`);
body = await session.findElementByCSS('body');
});
it('should show all property names by "set" command with empty params', async() => {
await body.sendKeys(':');
await session.switchToFrame(0);
let c = new Console(session);
await c.sendKeys('set ');
await eventually(async() => {
let items = await c.getCompletions();
assert.equal(items.length, 5);
assert.deepEqual(items[0], { type: 'title', text: 'Properties' });
assert(items[1].text.startsWith('hintchars'))
assert(items[2].text.startsWith('smoothscroll'))
assert(items[3].text.startsWith('nosmoothscroll'))
assert(items[4].text.startsWith('complete'))
});
});
it('should show filtered property names by "set" command', async() => {
await body.sendKeys(':');
await session.switchToFrame(0);
let c = new Console(session);
await c.sendKeys('set no');
await eventually(async() => {
let items = await c.getCompletions();
assert.equal(items.length, 2);
assert(items[1].text.includes('nosmoothscroll'))
});
});
});

10
e2e/lib/Console.js
Unescape View File

@ -8,6 +8,13 @@ class Console {
input.sendKeys(...keys); input.sendKeys(...keys);
} }
async currentValue() {
return await this.session.executeScript(() => {
let input = document.querySelector('input');
return input.value;
});
}
async getCompletions() { async getCompletions() {
return await this.session.executeScript(() => { return await this.session.executeScript(() => {
let items = document.querySelectorAll('.vimvixen-console-completion > li'); let items = document.querySelectorAll('.vimvixen-console-completion > li');
@ -20,7 +27,8 @@ class Console {
if (li.classList.contains('vimvixen-console-completion-title')) { if (li.classList.contains('vimvixen-console-completion-title')) {
objs.push({ type: 'title', text: li.textContent.trim() }); objs.push({ type: 'title', text: li.textContent.trim() });
} else if ('vimvixen-console-completion-item') { } else if ('vimvixen-console-completion-item') {
objs.push({ type: 'item', text: li.textContent.trim() }); let highlight = li.classList.contains('vimvixen-completion-selected');
objs.push({ type: 'item', text: li.textContent.trim(), highlight });
} else { } else {
throw new Error(`unexpected class: ${li.className}`); throw new Error(`unexpected class: ${li.className}`);
} }