jab2870/Vim-Vixen
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

use key instead of keyCode in follow

Browse source
This commit is contained in:
Shin'ya Ueoka 2017-10-08 08:58:11 +09:00
parent ea455059bd
commit 944683a2d8
4 changed files with 26 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

10
test/components/follow.test.js
View file

@ -2,16 +2,6 @@ import { expect } from "chai";
import FollowComponent from 'components/follow';
describe('FollowComponent', () => {
describe('#codeChars', () => {
it('returns a string for key codes', () => {
let chars = [
KeyboardEvent.DOM_VK_0, KeyboardEvent.DOM_VK_1,
KeyboardEvent.DOM_VK_A, KeyboardEvent.DOM_VK_B];
expect(FollowComponent.codeChars(chars)).to.equal('01ab');
expect(FollowComponent.codeChars([])).to.be.equal('');
});
});
describe('#getTargetElements', () => {
beforeEach(() => {
document.body.innerHTML = __html__['test/components/follow.html'];

20
test/reducers/follow.test.js
View file

@ -7,7 +7,7 @@ describe('follow reducer', () => {
let state = followReducer(undefined, {});
expect(state).to.have.property('enabled', false);
expect(state).to.have.property('newTab');
expect(state).to.have.deep.property('keys', []);
expect(state).to.have.deep.property('keys', '');
});
it ('returns next state for FOLLOW_ENABLE', () => {
@ -24,24 +24,24 @@ describe('follow reducer', () => {
});
it ('returns next state for FOLLOW_KEY_PRESS', () => {
let action = { type: actions.FOLLOW_KEY_PRESS, key: 100};
let state = followReducer({ keys: [] }, action);
expect(state).to.have.deep.property('keys', [100]);
let action = { type: actions.FOLLOW_KEY_PRESS, key: 'a'};
let state = followReducer({ keys: '' }, action);
expect(state).to.have.deep.property('keys', 'a');
action = { type: actions.FOLLOW_KEY_PRESS, key: 200};
action = { type: actions.FOLLOW_KEY_PRESS, key: 'b'};
state = followReducer(state, action);
expect(state).to.have.deep.property('keys', [100, 200]);
expect(state).to.have.deep.property('keys', 'ab');
});
it ('returns next state for FOLLOW_BACKSPACE', () => {
let action = { type: actions.FOLLOW_BACKSPACE };
let state = followReducer({ keys: [100, 200] }, action);
expect(state).to.have.deep.property('keys', [100]);
let state = followReducer({ keys: 'ab' }, action);
expect(state).to.have.deep.property('keys', 'a');
state = followReducer(state, action);
expect(state).to.have.deep.property('keys', []);
expect(state).to.have.deep.property('keys', '');
state = followReducer(state, action);
expect(state).to.have.deep.property('keys', []);
expect(state).to.have.deep.property('keys', '');
});
});