remove message propagation

src/content/components/common/follow.js

@@ -34,6 +34,8 @@ export default class Follow {
     this.newTab = false;
     this.hints = {};
     this.targets = [];
+
+    messages.onMessage(this.onMessage.bind(this));
   }
 
   update() {

src/content/components/common/index.js

@@ -21,18 +21,19 @@ export default class Common {
     ];
 
     this.reloadSettings();
+
+    messages.onMessage(this.onMessage.bind(this));
   }
 
   update() {
     this.children.forEach(c => c.update());
   }
 
-  onMessage(message, sender) {
+  onMessage(message) {
     switch (message.type) {
     case messages.SETTINGS_CHANGED:
       this.reloadSettings();
     }
-    this.children.forEach(c => c.onMessage(message, sender));
   }
 
   reloadSettings() {

src/content/components/common/input.js

@@ -69,7 +69,4 @@ export default class InputComponent {
           e.target.getAttribute('contenteditable').toLowerCase() === 'true' ||
           e.target.getAttribute('contenteditable').toLowerCase() === '');
   }
-
-  onMessage() {
-  }
 }

src/content/components/common/keymapper.js

@@ -28,7 +28,4 @@ export default class KeymapperComponent {
     this.store.dispatch(inputActions.clearKeys());
     return true;
   }
-
-  onMessage() {
-  }
 }

src/content/components/top-content/follow-controller.js

@@ -17,6 +17,8 @@ export default class FollowController {
     this.state = {};
     this.keys = [];
     this.producer = null;
+
+    messages.onMessage(this.onMessage.bind(this));
   }
 
   onMessage(message, sender) {

src/content/components/top-content/index.js

@@ -14,19 +14,20 @@ export default class TopContent {
 
     // TODO make component
     consoleFrames.initialize(window.document);
+
+    messages.onMessage(this.onMessage.bind(this));
   }
 
   update() {
     this.children.forEach(c => c.update());
   }
 
-  onMessage(message, sender) {
+  onMessage(message) {
     switch (message.type) {
     case messages.CONSOLE_HIDE_COMMAND:
       this.win.focus();
       consoleFrames.blur(window.document);
       return Promise.resolve();
     }
-    this.children.forEach(c => c.onMessage(message, sender));
   }
 }

src/content/index.js

@@ -14,16 +14,4 @@ store.subscribe(() => {
   rootComponent.update();
 });
 
-browser.runtime.onMessage.addListener(msg => rootComponent.onMessage(msg));
 rootComponent.update();
-
-window.addEventListener('message', (event) => {
-  let message = null;
-  try {
-    message = JSON.parse(event.data);
-  } catch (e) {
-    // ignore unexpected message
-    return;
-  }
-  rootComponent.onMessage(message, event.source);
-});

src/shared/messages.js

@@ -1,3 +1,26 @@
+const onWebMessage = (listener) => {
+  window.addEventListener('message', (event) => {
+    let sender = event.source;
+    let message = null;
+    try {
+      message = JSON.parse(event.data);
+    } catch (e) {
+      // ignore unexpected message
+      return;
+    }
+    listener(message, sender);
+  });
+};
+
+const onBackgroundMessage = (listener) => {
+  browser.runtime.onMessage.addListener(listener);
+};
+
+const onMessage = (listener) => {
+  onWebMessage(listener);
+  onBackgroundMessage(listener);
+};
+
 export default {
   BACKGROUND_OPERATION: 'background.operation',
 
@@ -23,4 +46,8 @@ export default {
   SETTINGS_RELOAD: 'settings.reload',
   SETTINGS_CHANGED: 'settings.changed',
   SETTINGS_QUERY: 'settings.query',
+
+  onWebMessage,
+  onBackgroundMessage,
+  onMessage,
 };