jab2870/Vim-Vixen
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

use validation on settings

Browse source
This commit is contained in:
Shin'ya Ueoka 2017-10-01 12:15:35 +09:00
parent 2d0968a70b
commit 8c9051076f
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/components/setting.js
View file

@ -1,4 +1,5 @@
import * as settingActions from '../actions/setting'; import * as settingActions from '../actions/setting';
import { validate } from '../shared/validators/setting';
export default class SettingComponent { export default class SettingComponent {
constructor(wrapper, store) { constructor(wrapper, store) {
@ -9,6 +10,9 @@ export default class SettingComponent {
let form = doc.getElementById('vimvixen-settings-form'); let form = doc.getElementById('vimvixen-settings-form');
form.addEventListener('submit', this.onSubmit.bind(this)); form.addEventListener('submit', this.onSubmit.bind(this));
let plainJson = form.elements['plain-json'];
plainJson.addEventListener('input', this.onPlainJsonChanged.bind(this));
store.dispatch(settingActions.load()); store.dispatch(settingActions.load());
} }
@ -20,6 +24,16 @@ export default class SettingComponent {
e.preventDefault(); e.preventDefault();
} }
onPlainJsonChanged(e) {
try {
let settings = JSON.parse(e.target.value);
validate(settings);
e.target.setCustomValidity('');
} catch (err) {
e.target.setCustomValidity(err.message);
}
}
update() { update() {
let { settings } = this.store.getState(); let { settings } = this.store.getState();