jab2870/Vim-Vixen
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

code review

Browse source 
* change default keybinding for pin/unpin tab from 'p' to 'zp'
 * use toggleTabPinned to toggle the tab pinned state, instead of updateTabPinned
This commit is contained in:
Jiabo Hou 2017-11-05 17:59:46 -05:00
parent c2d2f895a5
commit 87b8280d4b
4 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/background/tabs.js
View file

@ -103,16 +103,16 @@ const reload = (current, cache) => {
const updateTabPinned = (current, pinned) => {
return browser.tabs.query({ currentWindow: true, active: true })
.then(() => {
let newPinned = pinned;
if (newPinned !== true && newPinned !== false) {
newPinned = !current.pinned;
}
return browser.tabs.update(current.id, { pinned: newPinned });
return browser.tabs.update(current.id, { pinned: pinned });
});
};
const toggleTabPinned = (current) => {
updateTabPinned(current, !current.pinned);
};
export {
closeTab, reopenTab, selectAt, selectByKeyword, getCompletions,
selectPrevTab, selectNextTab, selectFirstTab, selectLastTab, reload,
updateTabPinned
updateTabPinned, toggleTabPinned
};