jab2870/Vim-Vixen
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

code review

Browse source 
* change default keybinding for pin/unpin tab from 'p' to 'zp'
 * use toggleTabPinned to toggle the tab pinned state, instead of updateTabPinned
This commit is contained in:
Jiabo Hou 2017-11-05 17:59:46 -05:00
parent c2d2f895a5
commit 87b8280d4b
4 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/background/actions/operation.js
View file

@ -10,6 +10,9 @@ const sendConsoleShowCommand = (tab, command) => {
});
};
// This switch statement is only gonna get longer as more
// features are added, so disable complexity check
/* eslint-disable complexity */
const exec = (operation, tab) => {
switch (operation.type) {
case operations.TAB_CLOSE:
@ -31,7 +34,7 @@ const exec = (operation, tab) => {
case operations.TAB_UNPIN:
return tabs.updateTabPinned(tab, false);
case operations.TAB_TOGGLE_PINNED:
return tabs.updateTabPinned(tab);
return tabs.toggleTabPinned(tab);
case operations.ZOOM_IN:
return zooms.zoomIn();
case operations.ZOOM_OUT:
@ -64,5 +67,6 @@ const exec = (operation, tab) => {
return Promise.resolve();
}
};
/* eslint-enable complexity */
export { exec };