code review

* change default keybinding for pin/unpin tab from 'p' to 'zp'
 * use toggleTabPinned to toggle the tab pinned state, instead of updateTabPinned

README.md

@@ -35,7 +35,7 @@ The default mappings are as follows:
 - <kbd>g0</kbd>, <kbd>g$</kbd>: select first or last tab
 - <kbd>r</kbd>: reload current tab
 - <kbd>R</kbd>: reload current tab without cache
-- <kbd>p</kbd>: toggle pin/unpin current tab
+- <kbd>zp</kbd>: toggle pin/unpin current tab
 
 ### Navigation
 - <kbd>f</kbd>: start following links in the page

src/background/actions/operation.js

@@ -10,6 +10,9 @@ const sendConsoleShowCommand = (tab, command) => {
   });
 };
 
+// This switch statement is only gonna get longer as more
+// features are added, so disable complexity check
+/* eslint-disable complexity */
 const exec = (operation, tab) => {
   switch (operation.type) {
   case operations.TAB_CLOSE:
@@ -31,7 +34,7 @@ const exec = (operation, tab) => {
   case operations.TAB_UNPIN:
     return tabs.updateTabPinned(tab, false);
   case operations.TAB_TOGGLE_PINNED:
-    return tabs.updateTabPinned(tab);
+    return tabs.toggleTabPinned(tab);
   case operations.ZOOM_IN:
     return zooms.zoomIn();
   case operations.ZOOM_OUT:
@@ -64,5 +67,6 @@ const exec = (operation, tab) => {
     return Promise.resolve();
   }
 };
+/* eslint-enable complexity */
 
 export { exec };

src/background/tabs.js

@@ -103,16 +103,16 @@ const reload = (current, cache) => {
 const updateTabPinned = (current, pinned) => {
   return browser.tabs.query({ currentWindow: true, active: true })
     .then(() => {
-      let newPinned = pinned;
-      if (newPinned !== true && newPinned !== false) {
-        newPinned = !current.pinned;
-      }
-      return browser.tabs.update(current.id, { pinned: newPinned });
+      return browser.tabs.update(current.id, { pinned: pinned });
     });
 };
 
+const toggleTabPinned = (current) => {
+  updateTabPinned(current, !current.pinned);
+};
+
 export {
   closeTab, reopenTab, selectAt, selectByKeyword, getCompletions,
   selectPrevTab, selectNextTab, selectFirstTab, selectLastTab, reload,
-  updateTabPinned
+  updateTabPinned, toggleTabPinned
 };

src/shared/default-settings.js

@@ -32,7 +32,7 @@ export default {
     "g$": { "type": "tabs.last" },
     "r": { "type": "tabs.reload", "cache": false },
     "R": { "type": "tabs.reload", "cache": true },
-    "p": { "type": "tabs.pin.toggle" },
+    "zp": { "type": "tabs.pin.toggle" },
     "zi": { "type": "zoom.in" },
     "zo": { "type": "zoom.out" },
     "zz": { "type": "zoom.neutral" },