Merge pull request #22 from ueokande/separate-domains

Refactor: Separate domains

manifest.json

@@ -6,7 +6,7 @@
   "content_scripts": [
     {
       "matches": [ "http://*/*", "https://*/*" ],
-      "js": [ "build/index.js" ]
+      "js": [ "build/content.js" ]
     }
   ],
   "background": {

src/background/actions/operation.js

@@ -1,10 +1,7 @@
 import operations from 'shared/operations';
-import messages from 'content/messages';
+import messages from 'shared/messages';
 import * as tabs from 'background/tabs';
 import * as zooms from 'background/zooms';
-import * as scrolls from 'content/scrolls';
-import * as navigates from 'content/navigates';
-import * as followActions from 'actions/follow';
 
 const sendConsoleShowCommand = (tab, command) => {
   return browser.tabs.sendMessage(tab.id, {
@@ -13,43 +10,7 @@ const sendConsoleShowCommand = (tab, command) => {
   });
 };
 
-const exec = (operation) => {
+const exec = (operation, tab) => {
-  switch (operation.type) {
-  case operations.SCROLL_LINES:
-    return scrolls.scrollLines(window, operation.count);
-  case operations.SCROLL_PAGES:
-    return scrolls.scrollPages(window, operation.count);
-  case operations.SCROLL_TOP:
-    return scrolls.scrollTop(window);
-  case operations.SCROLL_BOTTOM:
-    return scrolls.scrollBottom(window);
-  case operations.SCROLL_HOME:
-    return scrolls.scrollLeft(window);
-  case operations.SCROLL_END:
-    return scrolls.scrollRight(window);
-  case operations.FOLLOW_START:
-    return followActions.enable(false);
-  case operations.NAVIGATE_HISTORY_PREV:
-    return navigates.historyPrev(window);
-  case operations.NAVIGATE_HISTORY_NEXT:
-    return navigates.historyNext(window);
-  case operations.NAVIGATE_LINK_PREV:
-    return navigates.linkPrev(window);
-  case operations.NAVIGATE_LINK_NEXT:
-    return navigates.linkNext(window);
-  case operations.NAVIGATE_PARENT:
-    return navigates.parent(window);
-  case operations.NAVIGATE_ROOT:
-    return navigates.root(window);
-  default:
-    browser.runtime.sendMessage({
-      type: messages.BACKGROUND_OPERATION,
-      operation,
-    });
-  }
-};
-
-const execBackground = (operation, tab) => {
   switch (operation.type) {
   case operations.TAB_CLOSE:
     return tabs.closeTab(tab.id);
@@ -88,4 +49,4 @@ const execBackground = (operation, tab) => {
   }
 };
 
-export { exec, execBackground };
+export { exec };

src/background/components/background.js

@@ -1,7 +1,7 @@
-import messages from 'content/messages';
+import messages from 'shared/messages';
-import * as operationActions from 'actions/operation';
+import * as operationActions from 'background/actions/operation';
-import * as settingsActions from 'actions/setting';
+import * as settingsActions from 'settings/actions/setting';
-import * as tabActions from 'actions/tab';
+import * as tabActions from 'background/actions/tab';
 import * as commands from 'shared/commands';
 
 export default class BackgroundComponent {
@@ -23,7 +23,7 @@ export default class BackgroundComponent {
 
   update() {
     let state = this.store.getState();
-    this.updateSettings(state.setting);
+    this.updateSettings(state);
   }
 
   updateSettings(setting) {
@@ -37,7 +37,7 @@ export default class BackgroundComponent {
     switch (message.type) {
     case messages.BACKGROUND_OPERATION:
       return this.store.dispatch(
-        operationActions.execBackground(message.operation, sender.tab),
+        operationActions.exec(message.operation, sender.tab),
         sender);
     case messages.OPEN_URL:
       if (message.newTab) {
@@ -58,7 +58,7 @@ export default class BackgroundComponent {
         });
       });
     case messages.SETTINGS_QUERY:
-      return Promise.resolve(this.store.getState().setting.settings);
+      return Promise.resolve(this.store.getState().settings);
     case messages.CONSOLE_QUERY_COMPLETIONS:
       return commands.complete(message.text, this.settings);
     case messages.SETTINGS_RELOAD:

src/background/index.js

@@ -1,8 +1,8 @@
-import * as settingsActions from 'actions/setting';
+import * as settingsActions from 'settings/actions/setting';
-import messages from 'content/messages';
+import messages from 'shared/messages';
-import BackgroundComponent from 'components/background';
+import BackgroundComponent from 'background/components/background';
-import reducers from 'reducers';
+import reducers from 'settings/reducers/setting';
-import { createStore } from 'store';
+import { createStore } from 'shared/store';
 
 const store = createStore(reducers, (e, sender) => {
   console.error('Vim-Vixen:', e);

src/console/actions/console.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'console/actions';
 
 const showCommand = (text) => {
   return {

src/console/actions/index.js

@@ -0,0 +1,9 @@
+export default {
+  // console commands
+  CONSOLE_SHOW_COMMAND: 'console.show.command',
+  CONSOLE_SET_COMPLETIONS: 'console.set.completions',
+  CONSOLE_SHOW_ERROR: 'console.show.error',
+  CONSOLE_HIDE: 'console.hide',
+  CONSOLE_COMPLETION_NEXT: 'console.completion.next',
+  CONSOLE_COMPLETION_PREV: 'console.completion.prev',
+};

src/console/components/completion.js

@@ -6,7 +6,7 @@ export default class Completion {
   }
 
   update() {
-    let state = this.store.getState().console;
+    let state = this.store.getState();
     if (JSON.stringify(this.prevState) === JSON.stringify(state)) {
       return;
     }

src/console/components/console.js

@@ -1,5 +1,5 @@
-import messages from 'content/messages';
+import messages from 'shared/messages';
-import * as consoleActions from 'actions/console';
+import * as consoleActions from 'console/actions/console';
 
 export default class ConsoleComponent {
   constructor(wrapper, store) {
@@ -71,7 +71,7 @@ export default class ConsoleComponent {
   }
 
   update() {
-    let state = this.store.getState().console;
+    let state = this.store.getState();
     if (!this.prevState.commandShown && state.commandShown) {
       this.showCommand(state.commandText);
     } else if (!state.commandShown) {

src/console/index.js

@@ -1,10 +1,10 @@
-import './console.scss';
+import './site.scss';
-import messages from 'content/messages';
+import messages from 'shared/messages';
-import CompletionComponent from 'components/completion';
+import CompletionComponent from 'console/components/completion';
-import ConsoleComponent from 'components/console';
+import ConsoleComponent from 'console/components/console';
-import reducers from 'reducers';
+import reducers from 'console/reducers';
-import { createStore } from 'store';
+import { createStore } from 'shared/store';
-import * as consoleActions from 'actions/console';
+import * as consoleActions from 'console/actions/console';
 
 const store = createStore(reducers);
 let completionComponent = null;

src/console/reducers/index.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'console/actions';
 
 const defaultState = {
   errorShown: false,

src/content/actions/follow.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'content/actions';
 
 const enable = (newTab) => {
   return {

src/content/actions/index.js

@@ -1,12 +1,4 @@
 export default {
-  // console commands
-  CONSOLE_SHOW_COMMAND: 'console.show.command',
-  CONSOLE_SET_COMPLETIONS: 'console.set.completions',
-  CONSOLE_SHOW_ERROR: 'console.show.error',
-  CONSOLE_HIDE: 'console.hide',
-  CONSOLE_COMPLETION_NEXT: 'console.completion.next',
-  CONSOLE_COMPLETION_PREV: 'console.completion.prev',
-
   // User input
   INPUT_KEY_PRESS: 'input.key,press',
   INPUT_CLEAR_KEYS: 'input.clear.keys',

src/content/actions/input.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'content/actions';
 
 const asKeymapChars = (key, ctrl) => {
   if (ctrl) {

src/content/actions/operation.js

@@ -0,0 +1,43 @@
+import operations from 'shared/operations';
+import messages from 'shared/messages';
+import * as scrolls from 'content/scrolls';
+import * as navigates from 'content/navigates';
+import * as followActions from 'content/actions/follow';
+
+const exec = (operation) => {
+  switch (operation.type) {
+  case operations.SCROLL_LINES:
+    return scrolls.scrollLines(window, operation.count);
+  case operations.SCROLL_PAGES:
+    return scrolls.scrollPages(window, operation.count);
+  case operations.SCROLL_TOP:
+    return scrolls.scrollTop(window);
+  case operations.SCROLL_BOTTOM:
+    return scrolls.scrollBottom(window);
+  case operations.SCROLL_HOME:
+    return scrolls.scrollLeft(window);
+  case operations.SCROLL_END:
+    return scrolls.scrollRight(window);
+  case operations.FOLLOW_START:
+    return followActions.enable(false);
+  case operations.NAVIGATE_HISTORY_PREV:
+    return navigates.historyPrev(window);
+  case operations.NAVIGATE_HISTORY_NEXT:
+    return navigates.historyNext(window);
+  case operations.NAVIGATE_LINK_PREV:
+    return navigates.linkPrev(window);
+  case operations.NAVIGATE_LINK_NEXT:
+    return navigates.linkNext(window);
+  case operations.NAVIGATE_PARENT:
+    return navigates.parent(window);
+  case operations.NAVIGATE_ROOT:
+    return navigates.root(window);
+  default:
+    browser.runtime.sendMessage({
+      type: messages.BACKGROUND_OPERATION,
+      operation,
+    });
+  }
+};
+
+export { exec };

src/content/components/follow.js

@@ -1,5 +1,5 @@
-import * as followActions from 'actions/follow';
+import * as followActions from 'content/actions/follow';
-import messages from 'content/messages';
+import messages from 'shared/messages';
 import Hint from 'content/hint';
 import HintKeyProducer from 'content/hint-key-producer';
 

src/content/components/keymapper.js

@@ -1,5 +1,5 @@
-import * as inputActions from 'actions/input';
+import * as inputActions from 'content/actions/input';
-import * as operationActions from 'actions/operation';
+import * as operationActions from 'content/actions/operation';
 
 export default class KeymapperComponent {
   constructor(store) {

src/content/index.js

@@ -1,12 +1,12 @@
 import './console-frame.scss';
 import * as consoleFrames from './console-frames';
-import * as settingActions from 'actions/setting';
+import * as settingActions from 'settings/actions/setting';
-import { createStore } from 'store';
+import { createStore } from 'shared/store';
-import ContentInputComponent from 'components/content-input';
+import ContentInputComponent from 'content/components/content-input';
-import KeymapperComponent from 'components/keymapper';
+import KeymapperComponent from 'content/components/keymapper';
-import FollowComponent from 'components/follow';
+import FollowComponent from 'content/components/follow';
-import reducers from 'reducers';
+import reducers from 'content/reducers';
-import messages from './messages';
+import messages from 'shared/messages';
 
 const store = createStore(reducers);
 const followComponent = new FollowComponent(window.document.body, store);

src/content/reducers/follow.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'content/actions';
 
 const defaultState = {
   enabled: false,

src/content/reducers/index.js

@@ -1,11 +1,10 @@
-import inputReducer from 'reducers/input';
+import settingReducer from 'settings/reducers/setting';
-import consoleReducer from 'reducers/console';
+import inputReducer from './input';
-import settingReducer from 'reducers/setting';
+import followReducer from './follow';
-import followReducer from 'reducers/follow';
 
+// Make setting reducer instead of re-use
 const defaultState = {
   input: inputReducer(undefined, {}),
-  console: consoleReducer(undefined, {}),
   setting: settingReducer(undefined, {}),
   follow: followReducer(undefined, {}),
 };
@@ -13,7 +12,6 @@ const defaultState = {
 export default function reducer(state = defaultState, action = {}) {
   return Object.assign({}, state, {
     input: inputReducer(state.input, action),
-    console: consoleReducer(state.console, action),
     setting: settingReducer(state.setting, action),
     follow: followReducer(state.follow, action),
   });

src/content/reducers/input.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'content/actions';
 
 const defaultState = {
   keys: '',

src/settings/actions/index.js

@@ -0,0 +1,4 @@
+export default {
+  // Settings
+  SETTING_SET_SETTINGS: 'setting.set.settings',
+};

src/settings/actions/setting.js

@@ -1,5 +1,5 @@
-import actions from 'actions';
+import actions from 'settings/actions';
-import messages from 'content/messages';
+import messages from 'shared/messages';
 import DefaultSettings from 'shared/default-settings';
 
 const load = () => {

src/settings/components/setting.js

@@ -1,4 +1,4 @@
-import * as settingActions from 'actions/setting';
+import * as settingActions from 'settings/actions/setting';
 import { validate } from 'shared/validators/setting';
 
 export default class SettingComponent {

src/settings/index.js

@@ -1,7 +1,7 @@
-import './settings.scss';
+import './site.scss';
-import SettingComponent from 'components/setting';
+import SettingComponent from 'settings/components/setting';
-import settingReducer from 'reducers/setting';
+import settingReducer from 'settings/reducers/setting';
-import { createStore } from 'store';
+import { createStore } from 'shared/store';
 
 const store = createStore(settingReducer);
 let settingComponent = null;

src/settings/reducers/setting.js

@@ -1,4 +1,4 @@
-import actions from 'actions';
+import actions from 'settings/actions';
 
 const defaultState = {
   settings: {}

test/console/actions/console.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'console/actions';
-import * as consoleActions from 'actions/console';
+import * as consoleActions from 'console/actions/console';
 
 describe("console actions", () => {
   describe("showCommand", () => {

test/console/reducers/console.test.js

@@ -1,10 +1,10 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'console/actions';
-import consoleReducer from 'reducers/console';
+import reducer from 'console/reducers';
 
 describe("console reducer", () => {
   it('return the initial state', () => {
-    let state = consoleReducer(undefined, {});
+    let state = reducer(undefined, {});
     expect(state).to.have.property('errorShown', false);
     expect(state).to.have.property('errorText', '');
     expect(state).to.have.property('commandShown', false);
@@ -16,7 +16,7 @@ describe("console reducer", () => {
 
   it('return next state for CONSOLE_SHOW_COMMAND', () => {
     let action = { type: actions.CONSOLE_SHOW_COMMAND, text: 'open ' };
-    let state = consoleReducer({}, action);
+    let state = reducer({}, action);
     expect(state).to.have.property('commandShown', true);
     expect(state).to.have.property('commandText', 'open ');
     expect(state).to.have.property('errorShown', false);
@@ -24,7 +24,7 @@ describe("console reducer", () => {
 
   it('return next state for CONSOLE_SHOW_ERROR', () => {
     let action = { type: actions.CONSOLE_SHOW_ERROR, text: 'an error' };
-    let state = consoleReducer({}, action);
+    let state = reducer({}, action);
     expect(state).to.have.property('errorShown', true);
     expect(state).to.have.property('errorText', 'an error');
     expect(state).to.have.property('commandShown', false);
@@ -32,7 +32,7 @@ describe("console reducer", () => {
 
   it('return next state for CONSOLE_HIDE', () => {
     let action = { type: actions.CONSOLE_HIDE };
-    let state = consoleReducer({}, action);
+    let state = reducer({}, action);
     expect(state).to.have.property('errorShown', false);
     expect(state).to.have.property('commandShown', false);
   });
@@ -53,7 +53,7 @@ describe("console reducer", () => {
         items: [4, 5, 6]
       }]
     }
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('completions', action.completions);
     expect(state).to.have.property('groupSelection', -1);
     expect(state).to.have.property('itemSelection', -1);
@@ -73,16 +73,16 @@ describe("console reducer", () => {
       }]
     };
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', 0);
     expect(state).to.have.property('itemSelection', 0);
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', 0);
     expect(state).to.have.property('itemSelection', 1);
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', -1);
     expect(state).to.have.property('itemSelection', -1);
   });
@@ -101,16 +101,16 @@ describe("console reducer", () => {
       }]
     };
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', 1);
     expect(state).to.have.property('itemSelection', 0);
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', 0);
     expect(state).to.have.property('itemSelection', 1);
 
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
-    state = consoleReducer(state, action);
+    state = reducer(state, action);
     expect(state).to.have.property('groupSelection', -1);
     expect(state).to.have.property('itemSelection', -1);
   });

test/content/actions/follow.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'content/actions';
-import * as followActions from 'actions/follow';
+import * as followActions from 'content/actions/follow';
 
 describe('follow actions', () => {
   describe('enable', () => {

test/content/actions/input.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'content/actions';
-import * as inputActions from 'actions/input';
+import * as inputActions from 'content/actions/input';
 
 describe("input actions", () => {
   describe("keyPress", () => {

test/content/components/follow.test.js

@@ -1,10 +1,10 @@
 import { expect } from "chai";
-import FollowComponent from 'components/follow';
+import FollowComponent from 'content/components/follow';
 
 describe('FollowComponent', () => {
   describe('#getTargetElements', () => {
     beforeEach(() => {
-      document.body.innerHTML = __html__['test/components/follow.html'];
+      document.body.innerHTML = __html__['test/content/components/follow.html'];
     });
 
     it('returns visible links', () => {

test/content/reducers/follow.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'content/actions';
-import followReducer from 'reducers/follow';
+import followReducer from 'content/reducers/follow';
 
 describe('follow reducer', () => {
   it ('returns the initial state', () => {

test/content/reducers/input.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'content/actions';
-import inputReducer from 'reducers/input';
+import inputReducer from 'content/reducers/input';
 
 describe("input reducer", () => {
   it('return the initial state', () => {

test/settings/reducers/setting.test.js

@@ -1,6 +1,6 @@
 import { expect } from "chai";
-import actions from 'actions';
+import actions from 'settings/actions';
-import settingReducer from 'reducers/setting';
+import settingReducer from 'settings/reducers/setting';
 
 describe("setting reducer", () => {
   it('return the initial state', () => {

test/shared/store/index.test.js

@@ -1,5 +1,5 @@
 import { expect } from "chai";
-import { createStore } from 'store';
+import { createStore } from 'shared/store';
 
 describe("Store class", () => {
   const reducer = (state, action) => {

webpack.config.js

@@ -6,10 +6,10 @@ const dist = path.resolve(__dirname, 'build');
 
 module.exports = {
   entry: {
-    index: path.join(src, 'content'),
+    content: path.join(src, 'content'),
-    settings: path.join(src, 'pages/settings'),
+    settings: path.join(src, 'settings'),
     background: path.join(src, 'background'),
-    console: path.join(src, 'pages', 'console.js')
+    console: path.join(src, 'console')
   },
 
   output: {
@@ -45,12 +45,12 @@ module.exports = {
 
   plugins: [
     new HtmlWebpackPlugin({
-      template: path.join(src, 'pages', 'console.html'),
+      template: path.join(src, 'console', 'index.html'),
       filename: path.join(dist, 'console.html'),
       inject: false
     }),
     new HtmlWebpackPlugin({
-      template: path.join(src, 'pages', 'settings.html'),
+      template: path.join(src, 'settings', 'index.html'),
       filename: path.join(dist, 'settings.html'),
       inject: false
     })