From b5e5387121650ec9b4a3862131e97d08bdc9478f Mon Sep 17 00:00:00 2001 From: Maarten van Gompel Date: Fri, 23 Apr 2021 19:23:06 +0200 Subject: [PATCH] minor shellcheck fixes after applying latest patches --- scripts/core/sxmo_lock.sh | 2 +- scripts/core/sxmo_proximitylock.sh | 2 +- scripts/modem/sxmo_modemcall.sh | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/core/sxmo_lock.sh b/scripts/core/sxmo_lock.sh index c5f274f..b64c6e9 100755 --- a/scripts/core/sxmo_lock.sh +++ b/scripts/core/sxmo_lock.sh @@ -5,7 +5,7 @@ . "$(dirname "$0")/sxmo_common.sh" finish() { - kill $LOCKPID + kill "$LOCKPID" } trap 'finish' TERM INT diff --git a/scripts/core/sxmo_proximitylock.sh b/scripts/core/sxmo_proximitylock.sh index a0505e6..608c272 100644 --- a/scripts/core/sxmo_proximitylock.sh +++ b/scripts/core/sxmo_proximitylock.sh @@ -9,7 +9,7 @@ syncstate() { } finish() { - kill $(jobs -p) + kill "$(jobs -p)" syncstate [ free = "$STATE" ] && [ true = "$WASLOCKED" ] && sxmo_lock.sh & exit 0 diff --git a/scripts/modem/sxmo_modemcall.sh b/scripts/modem/sxmo_modemcall.sh index b5ac6bf..b2b98a6 100755 --- a/scripts/modem/sxmo_modemcall.sh +++ b/scripts/modem/sxmo_modemcall.sh @@ -25,14 +25,14 @@ finish() { echo "sxmo_modemcall: $1">&2 notify-send "$1" fi - [ -n "$LOCKPID" ] && kill $LOCKPID + [ -n "$LOCKPID" ] && kill "$LOCKPID" pkill -9 dmenu exit 1 } gracefulexit() { - kill $MAINPID - wait $MAINPID + kill "$MAINPID" + wait "$MAINPID" finish "Call ended" }