From 8ee22f303832d80382dabe05ae0710128b1b960a Mon Sep 17 00:00:00 2001 From: Miles Alan Date: Sat, 27 Jun 2020 20:50:06 -0500 Subject: [PATCH] Quote $@ where needed --- scripts/appscripts/sxmo_timer.sh | 3 +-- scripts/core/sxmo_dmenu_with_kb.sh | 3 +-- scripts/modem/sxmo_modemcall.sh | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/scripts/appscripts/sxmo_timer.sh b/scripts/appscripts/sxmo_timer.sh index eb685ba..f4ec14e 100755 --- a/scripts/appscripts/sxmo_timer.sh +++ b/scripts/appscripts/sxmo_timer.sh @@ -47,5 +47,4 @@ menu() { st -f Monospace-50 -e "$0" timerrun "$TIMEINPUT" } -# shellcheck disable=SC2068 -if [ $# -gt 0 ]; then $@; else menu; fi \ No newline at end of file +if [ $# -gt 0 ]; then "$@"; else menu; fi \ No newline at end of file diff --git a/scripts/core/sxmo_dmenu_with_kb.sh b/scripts/core/sxmo_dmenu_with_kb.sh index faa9d0f..aedefcb 100755 --- a/scripts/core/sxmo_dmenu_with_kb.sh +++ b/scripts/core/sxmo_dmenu_with_kb.sh @@ -1,7 +1,6 @@ #!/usr/bin/env sh pidof svkbd-sxmo >&2 || svkbd-sxmo & -# shellcheck disable=SC2068 -OUTPUT="$(cat | dmenu $@)" +OUTPUT="$(cat | dmenu "$@")" pkill svkbd-sxmo >&2 echo "$OUTPUT" diff --git a/scripts/modem/sxmo_modemcall.sh b/scripts/modem/sxmo_modemcall.sh index bc5eec0..869d021 100755 --- a/scripts/modem/sxmo_modemcall.sh +++ b/scripts/modem/sxmo_modemcall.sh @@ -29,8 +29,7 @@ contacts() { } modem_cmd_errcheck() { - # shellcheck disable=SC2068 - RES="$(mmcli $@ 2>&1)" + RES="$(mmcli "$@" 2>&1)" OK="$?" echo "Command: mmcli $*" if [ "$OK" != 0 ]; then fatalerr "Problem executing mmcli command!\n$RES"; fi