From 940f3c7f791b38262563dc05a905b8f7caabf769 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 8 Oct 2017 15:25:56 +0900 Subject: [PATCH 1/2] support winopen command --- src/shared/commands.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/shared/commands.js b/src/shared/commands.js index b1d8780..2d95e84 100644 --- a/src/shared/commands.js +++ b/src/shared/commands.js @@ -36,6 +36,10 @@ const tabopenCommand = (url) => { return browser.tabs.create({ url: url }); }; +const winopenCommand = (url) => { + return browser.windows.create({ url }); +}; + const bufferCommand = (keywords) => { return browser.tabs.query({ active: true, currentWindow: true @@ -87,11 +91,13 @@ const doCommand = (name, remaining, settings) => { switch (name) { case 'o': case 'open': - // TODO use search engined and pass keywords to them return openCommand(normalizeUrl(remaining, settings.search)); case 't': case 'tabopen': return tabopenCommand(normalizeUrl(remaining, settings.search)); + case 'w': + case 'winopen': + return winopenCommand(normalizeUrl(remaining, settings.search)); case 'b': case 'buffer': return bufferCommand(remaining); @@ -105,6 +111,8 @@ const getCompletions = (command, keywords, settings) => { case 'open': case 't': case 'tabopen': + case 'w': + case 'winopen': return getOpenCompletions(command, keywords, settings.search); case 'b': case 'buffer': From d262fd1a2f5d5c7864175acd54c910a064a42fc3 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 8 Oct 2017 15:29:37 +0900 Subject: [PATCH 2/2] support w/W command --- src/background/actions/operation.js | 6 ++++++ src/shared/default-settings.js | 2 ++ src/shared/operations.js | 1 + 3 files changed, 9 insertions(+) diff --git a/src/background/actions/operation.js b/src/background/actions/operation.js index d736c09..b94c117 100644 --- a/src/background/actions/operation.js +++ b/src/background/actions/operation.js @@ -42,6 +42,12 @@ const exec = (operation, tab) => { return sendConsoleShowCommand(tab, 'tabopen ' + tab.url); } return sendConsoleShowCommand(tab, 'tabopen '); + case operations.COMMAND_SHOW_WINOPEN: + if (operation.alter) { + // alter url + return sendConsoleShowCommand(tab, 'winopen ' + tab.url); + } + return sendConsoleShowCommand(tab, 'winopen '); case operations.COMMAND_SHOW_BUFFER: return sendConsoleShowCommand(tab, 'buffer '); default: diff --git a/src/shared/default-settings.js b/src/shared/default-settings.js index 3149581..d602117 100644 --- a/src/shared/default-settings.js +++ b/src/shared/default-settings.js @@ -7,6 +7,8 @@ export default { "O": { "type": "command.show.open", "alter": true }, "t": { "type": "command.show.tabopen", "alter": false }, "T": { "type": "command.show.tabopen", "alter": true }, + "w": { "type": "command.show.winopen", "alter": false }, + "W": { "type": "command.show.winopen", "alter": true }, "b": { "type": "command.show.buffer" }, "k": { "type": "scroll.lines", "count": -1 }, "j": { "type": "scroll.lines", "count": 1 }, diff --git a/src/shared/operations.js b/src/shared/operations.js index b68f59d..5e4a1e5 100644 --- a/src/shared/operations.js +++ b/src/shared/operations.js @@ -3,6 +3,7 @@ export default { COMMAND_SHOW: 'command.show', COMMAND_SHOW_OPEN: 'command.show.open', COMMAND_SHOW_TABOPEN: 'command.show.tabopen', + COMMAND_SHOW_WINOPEN: 'command.show.winopen', COMMAND_SHOW_BUFFER: 'command.show.buffer', // Scrolls