From b74acf6f6aef4e4241ba62c72ed8ddb21adc751d Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Sun, 17 Jun 2018 22:02:32 +0900
Subject: [PATCH] Use await/async on shared directory

---
 src/shared/settings/storage.js | 42 ++++++++++++++++------------------
 src/shared/versions/index.js   | 13 +++++------
 src/shared/versions/storage.js |  7 +++---
 3 files changed, 29 insertions(+), 33 deletions(-)

diff --git a/src/shared/settings/storage.js b/src/shared/settings/storage.js
index 9b8045d..87843ed 100644
--- a/src/shared/settings/storage.js
+++ b/src/shared/settings/storage.js
@@ -1,30 +1,28 @@
 import DefaultSettings from './default';
 import * as settingsValues from './values';
 
-const loadRaw = () => {
-  return browser.storage.local.get('settings').then(({ settings }) => {
-    if (!settings) {
-      return DefaultSettings;
-    }
-    return Object.assign({}, DefaultSettings, settings);
-  });
+const loadRaw = async() => {
+  let { settings } = await browser.storage.local.get('settings');
+  if (!settings) {
+    return DefaultSettings;
+  }
+  return Object.assign({}, DefaultSettings, settings);
 };
 
-const loadValue = () => {
-  return loadRaw().then((settings) => {
-    let value = JSON.parse(DefaultSettings.json);
-    if (settings.source === 'json') {
-      value = settingsValues.valueFromJson(settings.json);
-    } else if (settings.source === 'form') {
-      value = settingsValues.valueFromForm(settings.form);
-    }
-    if (!value.properties) {
-      value.properties = {};
-    }
-    return Object.assign({},
-      settingsValues.valueFromJson(DefaultSettings.json),
-      value);
-  });
+const loadValue = async() => {
+  let settings = await loadRaw();
+  let value = JSON.parse(DefaultSettings.json);
+  if (settings.source === 'json') {
+    value = settingsValues.valueFromJson(settings.json);
+  } else if (settings.source === 'form') {
+    value = settingsValues.valueFromForm(settings.form);
+  }
+  if (!value.properties) {
+    value.properties = {};
+  }
+  return Object.assign({},
+    settingsValues.valueFromJson(DefaultSettings.json),
+    value);
 };
 
 const save = (settings) => {
diff --git a/src/shared/versions/index.js b/src/shared/versions/index.js
index ee9f3b5..ba3d183 100644
--- a/src/shared/versions/index.js
+++ b/src/shared/versions/index.js
@@ -13,13 +13,12 @@ const notificationClickListener = (id) => {
   browser.notifications.onClicked.removeListener(notificationClickListener);
 };
 
-const checkUpdated = () => {
-  return storage.load().then((prev) => {
-    if (!prev) {
-      return true;
-    }
-    return manifest.version !== prev;
-  });
+const checkUpdated = async() => {
+  let prev = await storage.load();
+  if (!prev) {
+    return true;
+  }
+  return manifest.version !== prev;
 };
 
 const notify = () => {
diff --git a/src/shared/versions/storage.js b/src/shared/versions/storage.js
index 37603c8..7883258 100644
--- a/src/shared/versions/storage.js
+++ b/src/shared/versions/storage.js
@@ -1,7 +1,6 @@
-const load = () => {
-  return browser.storage.local.get('version').then(({ version }) => {
-    return version;
-  });
+const load = async() => {
+  let { version } = await browser.storage.local.get('version');
+  return version;
 };
 
 const save = (version) => {