From 784a0d4037b781ced23435a0c1301ed7adbac5fc Mon Sep 17 00:00:00 2001 From: Shin'ya UEOKA Date: Tue, 7 Aug 2018 22:01:51 +0000 Subject: [PATCH 1/3] Replace trimStart --- src/background/controllers/command.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/background/controllers/command.js b/src/background/controllers/command.js index befab42..9ab1054 100644 --- a/src/background/controllers/command.js +++ b/src/background/controllers/command.js @@ -2,6 +2,11 @@ import CompletionsInteractor from '../usecases/completions'; import CommandInteractor from '../usecases/command'; import Completions from '../domains/completions'; +const trimStart = (str) => { + // NOTE String.trimStart is available on Firefox 61 + return str.replace(/^\s+/, ''); +}; + export default class CommandController { constructor() { this.completionsInteractor = new CompletionsInteractor(); @@ -9,13 +14,13 @@ export default class CommandController { } getCompletions(line) { - let trimmed = line.trimStart(); + let trimmed = trimStart(line); let words = trimmed.split(/ +/); let name = words[0]; if (words.length === 1) { return this.completionsInteractor.queryConsoleCommand(name); } - let keywords = trimmed.slice(name.length).trimStart(); + let keywords = trimStart(trimmed.slice(name.length)); switch (words[0]) { case 'o': case 'open': @@ -45,14 +50,14 @@ export default class CommandController { // eslint-disable-next-line complexity exec(line) { - let trimmed = line.trimStart(); + let trimmed = trimStart(line); let words = trimmed.split(/ +/); let name = words[0]; if (words[0].length === 0) { return Promise.resolve(); } - let keywords = trimmed.slice(name.length).trimStart(); + let keywords = trimStart(trimmed.slice(name.length)); switch (words[0]) { case 'o': case 'open': From e11f2555b8e30e37f840f65e48e11b283acbc3bc Mon Sep 17 00:00:00 2001 From: Shin'ya UEOKA Date: Tue, 7 Aug 2018 22:02:57 +0000 Subject: [PATCH 2/3] Bump a version --- manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.json b/manifest.json index 5e7551d..689ae5f 100644 --- a/manifest.json +++ b/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "Vim Vixen", "description": "Vim Vixen", - "version": "0.16", + "version": "0.17", "icons": { "48": "resources/icon_48x48.png", "96": "resources/icon_96x96.png" From c1d927bd38b04a961cd058af4dd65d9dd9df2f88 Mon Sep 17 00:00:00 2001 From: Shin'ya UEOKA Date: Tue, 7 Aug 2018 22:35:30 +0000 Subject: [PATCH 3/3] Use Firefox ESR --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 11c1f95..495fc42 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -4,7 +4,7 @@ jobs: docker: - image: circleci/node:10-stretch-browsers environment: - - FIREFOX_VERSION: "60.0.2" + - FIREFOX_VERSION: "60.0esr" working_directory: ~ steps: - restore_cache: