From 1731bf1f5f9b0327aba3ec71b9b2a395404719d0 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 11 Feb 2019 20:17:01 +0900 Subject: [PATCH 1/2] Use FirefoxHeadless --- karma.conf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/karma.conf.js b/karma.conf.js index 7331331..5e69f9e 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -24,7 +24,7 @@ module.exports = function (config) { port: 9876, colors: true, logLevel: config.LOG_INFO, - browsers: ['Firefox'], + browsers: ['FirefoxHeadless'], singleRun: true, From fd125422e03cc5c9ee14bd913eea379202e76f9a Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 11 Feb 2019 20:19:34 +0900 Subject: [PATCH 2/2] Enable to bind space key --- src/shared/utils/keys.js | 3 +++ test/shared/utils/keys.test.js | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/src/shared/utils/keys.js b/src/shared/utils/keys.js index 4579fde..f024069 100644 --- a/src/shared/utils/keys.js +++ b/src/shared/utils/keys.js @@ -1,4 +1,7 @@ const modifiedKeyName = (name) => { + if (name === ' ') { + return 'Space'; + } if (name.length === 1) { return name; } else if (name === 'Escape') { diff --git a/test/shared/utils/keys.test.js b/test/shared/utils/keys.test.js index 770b530..b2ad3cb 100644 --- a/test/shared/utils/keys.test.js +++ b/test/shared/utils/keys.test.js @@ -35,6 +35,17 @@ describe("keys util", () => { expect(k.altKey).to.be.false; expect(k.metaKey).to.be.false; }); + + it('returns from keyboard input Crtl+Space', () => { + let k = keys.fromKeyboardEvent({ + key: ' ', shiftKey: false, ctrlKey: true, altKey: false, metaKey: false + }); + expect(k.key).to.equal('Space'); + expect(k.shiftKey).to.be.false; + expect(k.ctrlKey).to.be.true; + expect(k.altKey).to.be.false; + expect(k.metaKey).to.be.false; + }); }); describe('fromMapKey', () => { @@ -100,6 +111,15 @@ describe("keys util", () => { expect(key.altKey).to.be.false; expect(key.metaKey).to.be.false; }); + + it('returns for Ctrl+Esc', () => { + let key = keys.fromMapKey(''); + expect(key.key).to.equal('Space'); + expect(key.shiftKey).to.be.false; + expect(key.ctrlKey).to.be.true; + expect(key.altKey).to.be.false; + expect(key.metaKey).to.be.false; + }); }); describe('fromMapKeys', () => {