From 7c943eb675eba4790b33378f0e5ec1ffcff623c4 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Tue, 19 Sep 2017 22:23:23 +0900 Subject: [PATCH] click link and avoid invalid links --- src/content/index.js | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/content/index.js b/src/content/index.js index 159429e..8fb142a 100644 --- a/src/content/index.js +++ b/src/content/index.js @@ -9,15 +9,25 @@ import messages from '../messages'; consoleFrames.initialize(window.document); const startFollows = (newTab) => { - let follow = new Follow(window.document, newTab); + let follow = new Follow(window.document); follow.onActivated((element) => { switch (element.tagName.toLowerCase()) { case 'a': - return browser.runtime.sendMessage({ - type: messages.OPEN_URL, - url: element.href, - newTab - }); + if (newTab) { + // getAttribute() to avoid to resolve absolute path + let href = element.getibute('href'); + + // eslint-disable-next-line no-script-url + if (!href || href === '#' || href.startsWith('javascript:')) { + return; + } + return browser.runtime.sendMessage({ + type: messages.OPEN_URL, + url: element.href, + newTab + }); + } + return element.click(); case 'input': switch (element.type) { case 'file':