From 76e09c75127d86f4d32cb7fb31ffefc3fc021997 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Sun, 6 May 2018 22:00:23 +0900 Subject: [PATCH] Get completion items as Promises --- src/background/shared/completions/index.js | 27 +++++++++++++++------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/background/shared/completions/index.js b/src/background/shared/completions/index.js index 73b7b27..5bfdbfb 100644 --- a/src/background/shared/completions/index.js +++ b/src/background/shared/completions/index.js @@ -1,22 +1,33 @@ import * as tabs from './tabs'; import * as histories from './histories'; -const getOpenCompletions = (command, keywords, searchConfig) => { +const getSearchCompletions = (command, keywords, searchConfig) => { + let engineNames = Object.keys(searchConfig.engines); + let engineItems = engineNames.filter(name => name.startsWith(keywords)) + .map(name => ({ + caption: name, + content: command + ' ' + name + })); + return Promise.resolve(engineItems); +}; + +const getHistoryCompletions = (command, keywords) => { return histories.getCompletions(keywords).then((pages) => { - let historyItems = pages.map((page) => { + return pages.map((page) => { return { caption: page.title, content: command + ' ' + page.url, url: page.url }; }); - let engineNames = Object.keys(searchConfig.engines); - let engineItems = engineNames.filter(name => name.startsWith(keywords)) - .map(name => ({ - caption: name, - content: command + ' ' + name - })); + }); +}; +const getOpenCompletions = (command, keywords, searchConfig) => { + return Promise.all([ + getSearchCompletions(command, keywords, searchConfig), + getHistoryCompletions(command, keywords), + ]).then(([engineItems, historyItems]) => { let completions = []; if (engineItems.length > 0) { completions.push({