From 631827f4fadd33e605cd91f9f95ef54bc948f894 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 21 Oct 2019 20:44:17 +0900 Subject: [PATCH 1/4] Use Firefox 68.0 ESR --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 342842d..fec66bd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -5,7 +5,7 @@ executors: docker: - image: circleci/node:10-stretch-browsers environment: - - FIREFOX_VERSION: "60.0esr" + - FIREFOX_VERSION: "68.0esr" - GECKODRIVER_VERSION: "0.24.0" working_directory: ~ From 98345f4b8cf3c62d7623bf96926786edba0ded8f Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 21 Oct 2019 20:44:34 +0900 Subject: [PATCH 2/4] Update supported version --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5f35660..b36e837 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ For usage and more detailed information, check out our [documentations][document ## Compatibility -- Firefox 60 ESR +- Firefox 68 ESR ## Copyright From c3752111c53e393fca109ac4c07bed5cb47be08c Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 21 Oct 2019 20:52:18 +0900 Subject: [PATCH 3/4] Update docs --- docs/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.md b/docs/index.md index 7917645..b7e8624 100644 --- a/docs/index.md +++ b/docs/index.md @@ -13,7 +13,7 @@ since it uses the WebExtensions API. ### Install Vim Vixen -Vim Vixen is supported on Firefox 60 ESR. Please latest version of stable ESR +Vim Vixen is supported on Firefox 68 ESR. Please latest version of stable ESR from the [download page](https://www.mozilla.org/en-US/firefox/). You can install Vim Vixen from [Firefox add-ons (addons.mozilla.org)][AMO], and manage installed addon-ons on Firefox preferences `about:preferences`. From a97a395bc3cc00c56b8ab79b72c50adad5f787a3 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 21 Oct 2019 20:52:37 +0900 Subject: [PATCH 4/4] Fix e2e test --- e2e/options_form.test.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/e2e/options_form.test.ts b/e2e/options_form.test.ts index c3dc5fb..75384a1 100644 --- a/e2e/options_form.test.ts +++ b/e2e/options_form.test.ts @@ -38,8 +38,6 @@ describe("options form page", () => { it('add blacklist item', async () => { let page = await OptionPage.open(lanthan); let forms = await page.switchToForm(); - // Scroll is required to click a button on Firefox 60 - await page.scrollTo(0, 1000); // assert default let settings = (await browser.storage.local.get('settings')).settings; @@ -67,8 +65,6 @@ describe("options form page", () => { it('add a partial blacklist item', async () => { let page = await OptionPage.open(lanthan); let forms = await page.switchToForm(); - // Scroll is required to click a button on Firefox 60 - await page.scrollTo(0, 1000); // assert default let settings = (await browser.storage.local.get('settings')).settings;