From 34bd084a4d0d3823764e3fb78378795aba9534d3 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 5 Aug 2019 21:48:46 +0900 Subject: [PATCH] Open options page on banner click --- src/background/presenters/NotifyPresenter.ts | 11 ++++++++++- src/background/usecases/SettingUseCase.ts | 4 +++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/background/presenters/NotifyPresenter.ts b/src/background/presenters/NotifyPresenter.ts index 9785278..defb601 100644 --- a/src/background/presenters/NotifyPresenter.ts +++ b/src/background/presenters/NotifyPresenter.ts @@ -26,11 +26,20 @@ export default class NotifyPresenter { }); } - async notifyInvalidSettings(): Promise { + async notifyInvalidSettings(onclick: () => void): Promise { let title = `Loaded settings is invalid`; // eslint-disable-next-line max-len let message = 'The default settings is used due to the last saved settings is invalid. Check your current settings from the add-on preference'; + const listener = (id: string) => { + if (id !== NOTIFICATION_ID_INVALID_SETTINGS) { + return; + } + onclick(); + browser.notifications.onClicked.removeListener(listener); + }; + browser.notifications.onClicked.addListener(listener); + await browser.notifications.create(NOTIFICATION_ID_INVALID_SETTINGS, { 'type': 'basic', 'iconUrl': browser.extension.getURL('resources/icon_48x48.png'), diff --git a/src/background/usecases/SettingUseCase.ts b/src/background/usecases/SettingUseCase.ts index 53c8f1d..ee131c7 100644 --- a/src/background/usecases/SettingUseCase.ts +++ b/src/background/usecases/SettingUseCase.ts @@ -30,7 +30,9 @@ export default class SettingUseCase { try { value = data.toSettings(); } catch (e) { - this.notifyPresenter.notifyInvalidSettings(); + this.notifyPresenter.notifyInvalidSettings(() => { + browser.runtime.openOptionsPage(); + }); value = DefaultSettingData.toSettings(); } this.settingRepository.update(value!!);