From 7bdf73d58c6b688bd61edfbe84940c52fa2abdc1 Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Tue, 15 May 2018 21:48:12 +0900
Subject: [PATCH 1/4] Add test cases

---
 QA.md | 44 ++++++++++++++++++++++++++++++++++++--------
 1 file changed, 36 insertions(+), 8 deletions(-)

diff --git a/QA.md b/QA.md
index e6adef4..0ecf292 100644
--- a/QA.md
+++ b/QA.md
@@ -17,7 +17,8 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] <kbd>:</kbd>: open empty console
 - [ ] <kbd>o</kbd>, <kbd>t</kbd>, <kbd>w</kbd>: open a console with `open`, `tabopen`, `winopen`
 - [ ] <kbd>O</kbd>, <kbd>T</kbd>, <kbd>W</kbd>: open a console with `open`, `tabopen`, `winopen` and current URL
-- [ ] <kbd>b</kbd>: open a consolw with `buffer`
+- [ ] <kbd>b</kbd>: open a console with `buffer`
+- [ ] <kbd>a</kbd>: open a console with `addbookmark` and the current page's title
 
 #### Tabs
 
@@ -26,11 +27,16 @@ The behaviors of the console are tested in [Console section](#consoles).
 
 #### Misc
 
+- [ ] <kbd>g</kbd><kbd>f</kbd>: open page source in the new tab.
 - [ ] <kbd>y</kbd>: yank current URL and show a message
-- [ ] <kbd>p</kbd>: open clipbord's URL in current tab
-- [ ] <kbd>P</kbd>: open clipbord's URL in new tab
+- [ ] <kbd>p</kbd>: open clipboard's URL in current tab
+- [ ] <kbd>P</kbd>: open clipboard's URL in new tab
 - [ ] Toggle enabled/disabled of plugin bu <kbd>Shift</kbd>+<kbd>Esc</kbd>
 - [ ] Hide error and info console by <kbd>Esc</kbd>
+- [ ] Vim-Vixen icons changes on <kbd>Shift</kbd>+<kbd>Esc</kbd>
+- [ ] Add-on is enabled and disabled by clicking the indicator on the tool bar.
+- [ ] The indicator changed on selected tab changed (changes add-on enabled)
+- [ ] Notify to users on add-on updated at first time.
 
 ### Following links
 
@@ -40,8 +46,11 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] Select link and open it in the frame in `<iframe>`/`<frame`> on following by <kbd>f</kbd>
 - [ ] Select link and open it in new tab in `<iframe>`/`<frame`> on following by <kbd>F</kbd>
 - [ ] Select link and open it in `<area>` tags, for <kbd>f</kbd> and <kbd>F</kbd>
+- [ ] Open new tab in background by `"background": true`
 - [ ] Configure custom hint character by `:set hintchars=012345678`
-- [ ] Configure custom hint character by settings `"hintchars": "012345678"`
+- [ ] Configure custom hint character by settings `"hintchars": "012345678"` in add-on preferences
+- [ ] Configure adjacent tab by `:set adjacenttab`
+- [ ] Configure adjacent tab by settings `adjacenttab: true` in add-on preferences
 - [ ] Opened tabs is in child on Tree Style Tab
 
 ### Consoles
@@ -59,8 +68,8 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] `open`,`open<SP>`: open default search engine
 <br>
 
-- [ ] `tabopen`: do avobe tests replaced `open` with `tabopen`, and verify the page is opened in new tab
-- [ ] `winopen`: do avobe tests replaced `open` with `winopen`, and verify the page is opened in new window
+- [ ] `tabopen`: do above tests replaced `open` with `tabopen`, and verify the page is opened in new tab
+- [ ] `winopen`: do above tests replaced `open` with `winopen`, and verify the page is opened in new window
 <br>
 
 - [ ] `buffer`,`buffer<SP>`: do nothing
@@ -68,6 +77,19 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] `buffer 1`: select leftmost tab
 - [ ] `buffer 0`, `buffer <a number more than count of tabs>`: shows an error
 - [ ] select tabs rotationally when more than two tabs are matched
+<br>
+
+- [ ] `addbookmark` creates a bookmark
+<br>
+
+- [ ] `q`, `quit`: close current tab
+- [ ] `bdelete`: delete a not-pinned tab matches with keywords
+- [ ] `bdelete`: show errors no-tabs or more than 1 tabs matched
+- [ ] `bdelete`: can not delete pinned tab
+- [ ] `bdelete!`: delete a tab matches with keywords
+- [ ] `bdelete!`: delete a pinned tab matches with keywords
+- [ ] `bdeletes`: delete tabs with matched with keywords excluding pinned
+- [ ] `bdeletes!`: delete tabs with matched with keywords including pinned
 
 ### Completions
 
@@ -77,9 +99,10 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] `open<SP>`: show all engines and some history items
 - [ ] `open g`: complete search engines starts with `g` and matched with keywords `g`
 - [ ] `open foo bar`: complete history items matched with keywords `foo` and `bar`
+- [ ] The completions shows histories, search engines, and bookmarks.
 - [ ] also `tabopen` and `winopen`
 - shortening commands such as `o` are not test in this release
-- [ ] Show competions for `:open`/`:tabopen`/`:buffer` on opning just after closed
+- [ ] Show completions for `:open`/`:tabopen`/`:buffer` on opening just after closed
 
 #### Buffer command
 
@@ -87,6 +110,11 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] `buffer<SP>`: show all opened tabs in completion
 - [ ] `buffer x`: show tabs which has title and URL matches with `x`
 
+#### Buffer command
+
+- [ ] `bdelete`, `bdeletes`: show tabs excluding pinned tabs
+- [ ] `bdelete!`, `bdeletes!`: show tabs including pinned tabs
+
 #### Misc
 
 - [ ] Select next item by <kbd>Tab</kbd> and previous item by <kbd>Shift</kbd>+<kbd>Tab</kbd>
@@ -165,7 +193,7 @@ The behaviors of the console are tested in [Console section](#consoles).
 - [ ] able to scroll on Gmail and Slack
 - [ ] Focus text box on Twitter or Slack, press <kbd>j</kbd>, then <kbd>j</kbd> is typed in the box
 - [ ] Focus the text box on Twitter or Slack on following mode
-- [ ] Tha pages is shown in https://pitchify.com/
+- [ ] The pages is shown in https://pitchify.com/
 - [ ] Open console in http://www.espncricinfo.com/
 
 ## Find mode

From cf5fc92b468186b7b5adc9720ca09c64cbd94098 Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Wed, 16 May 2018 20:50:13 +0900
Subject: [PATCH 2/4] Fix quit command

---
 src/background/actions/command.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/background/actions/command.js b/src/background/actions/command.js
index 39e880d..f1ee5b5 100644
--- a/src/background/actions/command.js
+++ b/src/background/actions/command.js
@@ -20,7 +20,9 @@ const tabopenCommand = (url) => {
 };
 
 const tabcloseCommand = () => {
-  return browser.tabs.query({ active: true }).then((tabList) => {
+  return browser.tabs.query({
+    active: true, currentWindow: true
+  }).then((tabList) => {
     return browser.tabs.remove(tabList.map(tab => tab.id));
   });
 };

From 6b2aa663aaa51e3b697052178dadbded9d14321b Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Wed, 16 May 2018 21:42:14 +0900
Subject: [PATCH 3/4] Improve README

---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 5c9c5e0..a4a7418 100644
--- a/README.md
+++ b/README.md
@@ -24,6 +24,7 @@ The default mappings are as follows:
 - <kbd>o</kbd>, <kbd>t</kbd>, <kbd>w</kbd>: open a page in current tab, new tab, or new window
 - <kbd>O</kbd>, <kbd>T</kbd>, <kbd>W</kbd>: similar to <kbd>o</kbd>, <kbd>t</kbd>, <kbd>w</kbd>, but that contains current URL
 - <kbd>b</kbd>: Select tabs by URL or title
+- <kbd>a</kbd>: add current page to the bookmarks
 
 #### Tabs
 - <kbd>!</kbd><kbd>d</kbd>: delete pinned tab

From 39959d75ce5879409e02f1071c8cc572ef5d8d3e Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Wed, 16 May 2018 21:42:22 +0900
Subject: [PATCH 4/4] Add commands to settings form

---
 src/settings/components/form/keymaps-form.jsx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/settings/components/form/keymaps-form.jsx b/src/settings/components/form/keymaps-form.jsx
index c830d95..f0f69cf 100644
--- a/src/settings/components/form/keymaps-form.jsx
+++ b/src/settings/components/form/keymaps-form.jsx
@@ -51,6 +51,7 @@ const KeyMapFields = [
     ['command.show.winopen?{"alter":false}', 'Open URL in new window'],
     ['command.show.winopen?{"alter":true}', 'Alter URL in new window'],
     ['command.show.buffer', 'Open buffer command'],
+    ['command.show.addbookmark?{"alter":true}', 'Open addbookmark command'],
   ], [
     ['addon.toggle.enabled', 'Enable or disable'],
     ['urls.yank', 'Copy current URL'],
@@ -59,6 +60,7 @@ const KeyMapFields = [
     ['zoom.in', 'Zoom-in'],
     ['zoom.out', 'Zoom-out'],
     ['zoom.neutral', 'Reset zoom level'],
+    ['page.source', 'Open a page source'],
   ]
 ];