From 0bd04565924a29d469ae43d533eb9e2204648bc9 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Wed, 25 Oct 2017 21:54:15 +0900 Subject: [PATCH 1/3] Update QA --- QA.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/QA.md b/QA.md index f9c4109..cdcd4a1 100644 --- a/QA.md +++ b/QA.md @@ -125,3 +125,24 @@ The behaviors of the console are tested in [Console section](#consoles). #### Empty suggestion (#65) - [ ] Show competions for `:open`/`:tabopen`/`:buffer` on console after closed + +#### Disable add-on temporary (#86) + +- [ ] Toggle enabled/disabled of plugin bu Shift+Esc + +#### URL blacklist (#90) + +- [ ] `github.com/a` blocks `github.com/a`, and not blocks `github.com/aa` +- [ ] `github.com/a*` blocks both `github.com/a` and `github.com/aa` +- [ ] `github.com/` blocks `github.com/`, and not blocks `github.com/a` +- [ ] `github.com` blocks both `github.com/` and `github.com/a` +- [ ] `*.github.com` blocks `gist.github.com/`, and not `github.com` + +#### Improve for aberration pages (#93) + +- [ ] able to scroll on Gmail and Slack + +#### Link with target='_blank' link (#94) + +- [ ] open link with target='_blank' in new tab by f +- [ ] open link with target='_blank' in new tab by F From d1f456dca0cfb70383005b955745ac1f90065cf5 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Wed, 25 Oct 2017 21:57:02 +0900 Subject: [PATCH 2/3] fix page scroll --- src/content/scrolls.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/content/scrolls.js b/src/content/scrolls.js index eda1946..a975296 100644 --- a/src/content/scrolls.js +++ b/src/content/scrolls.js @@ -75,9 +75,9 @@ const scrollHorizonally = (win, count) => { const scrollPages = (win, count) => { let target = scrollTarget(win); - let height = target.innerHeight; + let height = target.clientHeight; let x = target.scrollLeft; - let y = target.scrollLeft + height * count; + let y = target.scrollTop + height * count; target.scrollTo(x, y); }; From 73b4bc380d1ed5f7ef61d078ffd3e4a187c3c07e Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Thu, 26 Oct 2017 20:29:08 +0900 Subject: [PATCH 3/3] update QA --- QA.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/QA.md b/QA.md index cdcd4a1..798128e 100644 --- a/QA.md +++ b/QA.md @@ -92,7 +92,7 @@ The behaviors of the console are tested in [Console section](#consoles). ##### Validations - [ ] show error on invalid json -- [ ] show error when top-level keys has keys other than `keymaps`, and `search` +- [ ] show error when top-level keys has keys other than `keymaps`, `search`, and `blacklist` ##### `"keymaps"` section